Add workaround for handling unexpected pop ups during redirection maven build to editor #14814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
musienko-maxim
requested review from
l0rd,
nickboldt,
Ohrimenko1988 and
rhopp
as code owners
che-bot
added
kind/enhancement
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
dmytro-ndp
approved these changes
Oct 8, 2019
che-bot
removed
the
status/code-review
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
| // await projectTree.expandPathAndOpenFileInAssociatedWorkspace(projectName, 'build-output.txt'); | ||
| await projectTree.expandPathAndOpenFileInAssociatedWorkspace(projectName, 'result-build-output.txt', 220000); | ||
| await editor.waitText('result-build-output.txt', '[INFO] BUILD SUCCESS'); | ||
| // await editor.followAndWaitForText('build-output.txt', '[INFO] BUILD SUCCESS', 300000, 10000); |
There was a problem hiding this comment.
@musienko-maxim Why did you left commented code? In my opinion this is not a very good approach.
|
|
||
| //workaround for issue: https://github.com/eclipse/che/issues/14771 | ||
|
|
||
| /*await projectTree.expandPathAndOpenFileInAssociatedWorkspace(projectName, 'build.txt'); |
There was a problem hiding this comment.
The same question #14814 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
during adding new lines into editor, looks like sometimes filewatcher detect events incorrectly (the file from editor is not changed but filewatcher detect like changed).
For workaround we changed
execcommands in DevFile. After finishing maven build we grep last lines in a log file and check maven build was success or not. In this way, we do not redirect output to the editor and problem is not reproduced.What issues does this PR fix or reference?