Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable cors on master. Cleanup cors configuration on ws-agent #14921

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Disable cors on master. Cleanup cors configuration on ws-agent #14921

merged 2 commits into from
Oct 18, 2019

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Oct 18, 2019 •
edited
Loading

What does this PR do?

  • Makes cors disabled by default on Che Master
  • Removed cors configuration for Che 6 workspace agents

What issues does this PR fix or reference?

n/a

Release Notes

n/a

Docs PR

n/a

@skabashnyuk
Disable cors on master. Cleanup cors configuration on ws-agent
d7c7667 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
fixup! Disable cors on master. Cleanup cors configuration on ws-agent…
64ee025 
… Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot che-bot added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Oct 18, 2019
@che-bot
Copy link
Contributor

che-bot commented Oct 18, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Oct 18, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@benoitf
Copy link
Contributor

benoitf commented Oct 18, 2019

hello, what's the related issue ?

@skabashnyuk
Copy link
Contributor Author

https://bugs.eclipse.org/bugs/show_bug.cgi?id=551596

@skabashnyuk
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Oct 18, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

l0rd
l0rd approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested setting CHE_CORS_ENABLED=false and the issue get fixed +1 to merge

@skabashnyuk skabashnyuk merged commit 0134cb4 into master Oct 18, 2019
@skabashnyuk skabashnyuk deleted the cors_new1 branch October 18, 2019 13:44
skabashnyuk added a commit that referenced this pull request Oct 22, 2019
@skabashnyuk
Disable cors on master. Cleanup cors configuration on ws-agent (#14921)
f3acdeb 
* Disable cors on master. Cleanup cors configuration on ws-agent
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
skabashnyuk added a commit that referenced this pull request Oct 23, 2019
@skabashnyuk
Disable cors on master. Cleanup cors configuration on ws-agent (#14921)…
a8ce443 
… (#14952)

* Disable cors on master. Cleanup cors configuration on ws-agent
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk skabashnyuk mentioned this pull request Jan 9, 2020
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshaposhnik mshaposhnik mshaposhnik approved these changes

@l0rd l0rd l0rd approved these changes

@ibuziuk ibuziuk Awaiting requested review from ibuziuk

@metlos metlos Awaiting requested review from metlos

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skabashnyuk @che-bot @benoitf @l0rd @mshaposhnik