Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override entrypoint for remote binary. #14969

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Oct 23, 2019

What does this PR do?

Don't override entrypoint for remote binary.

What issues does this PR fix or reference?

#13387

Docs PR

eclipse-che/che-docs#879

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Oct 23, 2019
@che-bot
Copy link
Contributor

che-bot commented Oct 23, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Oct 23, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@AndrienkoAleksandr AndrienkoAleksandr merged commit d604bb4 into master Oct 24, 2019
@AndrienkoAleksandr AndrienkoAleksandr deleted the dontOverrideEntryPointForRemoteRuntime branch October 24, 2019 07:04
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 24, 2019
@che-bot che-bot added this to the 7.4.0 milestone Oct 24, 2019
@che-bot
Copy link
Contributor

che-bot commented Nov 13, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 13, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants