Do not use spy in ServerCheckerTest #14975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
skabashnyuk
requested review from
l0rd,
metlos,
mshaposhnik,
nickboldt,
rhopp and
sleshchenko
as code owners
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
sleshchenko
approved these changes
Oct 24, 2019
che-bot
added
the
status/code-review
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
metlos
approved these changes
Oct 24, 2019
che-bot
removed
the
status/code-review
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove usage of Mockito.spy from ServerCheckerTest.
It turns out that 5-6 times from 10000 spy can return an unpredictable results.
What issues does this PR fix or reference?
A lot of complains about failed ServerCheckerTest on CI
Release Notes
n/a
Docs PR
n/a