Improve docs and devfile on workspace loader development flow #15125
Conversation
mmorhun
requested review from
evidolob,
vitaliy-guliy,
AndrienkoAleksandr and
akurinnoy
mmorhun
requested review from
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
che-bot
added
the
status/code-review
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
CONTRIBUTING.md
Outdated
|
|
||
| To be able to point new workspace loader to the test workspace it is required to add the the test workspace id to the path of workspace loader route. | ||
| So, first, we need to retrieve the test workspace id. | ||
| This could be done using swagger (please note, it might be disable on production environment). |
There was a problem hiding this comment.
User could grab workspaceId like env variable from any workspace container, so maybe it is better to apply this information instead of swagger.
There was a problem hiding this comment.
Yes, this is useful information, however requires to have running workspace. I think it would be better to not to require running state of the test workspace (because in many cases workspace loader should be tested with workspace start flow).
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
mmorhun
force-pushed
the
improve-docs-ws-loader-dev-flow
branch
from
59101e7
to
e512b53
Compare
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
mmorhun
force-pushed
the
improve-docs-ws-loader-dev-flow
branch
from
e512b53
to
267c1aa
Compare
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
che-bot
removed
the
status/code-review
…e-che#15125) Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
What does this PR do?
Improves docs in CONTRIBUTING.md file which describes development and testing flow of workspace loader.
Also adds sparse checkout parameter into the workspace loader devfile to have only workspace loader source code instaed of whole Che repository.