Improved messages for self-signed cert issues #15951

olexii4 · 2020-02-06T14:49:03Z

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Improved messages for the self-signed cert issue.

What issues does this PR fix or reference?

#15298

Release Notes

Docs PR

che-bot · 2020-02-06T14:49:06Z

Can one of the admins verify this patch?

che-bot · 2020-02-06T15:14:05Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:15951

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

che-bot · 2020-02-06T15:20:51Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:15951

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

che-bot · 2020-02-06T15:49:29Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:15951

che-bot · 2020-02-06T16:20:23Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:15951

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

sleshchenko · 2020-02-06T16:20:48Z

@l0rd @beaumorley Could you please validate the error message we provide. Maybe you have some suggestions.

sleshchenko · 2020-02-06T17:03:30Z

Well, there is no easy way to get CA by the end-user. It makes me think that it would be great if Che Server serves CA and gives users an ability to download it as a file. But I'm not sure if it's really secure thing to do.
@mmorhun @skabashnyuk @skryzhny WDYT?

che-bot · 2020-02-06T17:03:51Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:15951

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

beaumorley · 2020-02-06T17:32:00Z

One simple thing I'd suggest is to change the text color on the error. The orange on black is hard to read. If you want to keep some orange to indicate that it is an important error, possibly just keep the headline orange? If this is a product wide convention to use orange, we may want to address it more holistically later but just wanted to bring it up.

** current error copy **
Unknown Error

Probably, one of Che hosts is signed with a self-signed certificate. Possible solutions would be:
1.) Import CA info your browser, you an find instructions how to do it by documentation
Open the link in a new tab and add an exclusion for this host and refresh Dashboard.

Click here to reload page.

** first stab at suggested improvements to error copy ***
Certificate Error

Your Che host may be signed with a self-signed certificate. To resolve this issue, try these possible solutions:
1.) Import CA info into your browser. You can find instructions on how to do this in your [Che documentation] (link).
2.) Open [the link for your Che host] (link) in a new tab and add an exclusion.

After trying each of these solutions, [refresh your Dashboard] (link) to see if the problem has been resolved
**

If I have some of the troubleshooting wrong, let me know and I can try and tweak this.

che-bot · 2020-02-06T17:48:32Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:15951

dashboard/src/app/index.module.ts

olexii4 · 2020-02-12T07:41:49Z

@beaumorley WDYT?

che-bot · 2020-02-12T07:51:47Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:15951
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

che-bot · 2020-02-12T07:57:13Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15951

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2020-02-12T08:09:26Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:15951

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

dashboard/src/components/branding/branding.service.ts

dashboard/src/components/branding/che-dashboard-configuration.service.ts

dashboard/src/app/organizations/organizations-config.service.spec.ts

beaumorley · 2020-02-12T13:23:14Z

This looks great. Very clear and easy to read. Thanks!

beaumorley · 2020-02-12T14:24:45Z

Just had a thought on this new design. We need a close button or an X at the top right of the screen (next to the Certificate Error title). If the user does not want to do any of the suggested options they should have a way to just cancel. Sorry I missed this. I think it is pretty important to add.

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 · 2020-02-13T20:15:13Z

done

che-bot · 2020-02-13T20:28:28Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:15951
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

che-bot · 2020-02-13T20:42:42Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:15951

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

che-bot · 2020-02-14T10:15:11Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:15951

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

che-bot · 2020-02-14T10:29:42Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:15951

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

che-bot · 2020-02-14T11:09:59Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:15951
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

che-bot · 2020-02-14T15:14:27Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15951

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

olexii4 · 2020-02-14T15:19:27Z

crw-ci-test

che-bot · 2020-02-14T15:44:43Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:15951

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

che-bot · 2020-02-14T15:50:54Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:15951
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

che-bot · 2020-02-14T17:01:20Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:15951

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

che-bot · 2020-02-14T18:08:28Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:15951

olexii4 requested review from sleshchenko and akurinnoy February 6, 2020 14:49

olexii4 requested review from ashumilova, benoitf, l0rd, nickboldt and rhopp as code owners February 6, 2020 14:49

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Feb 6, 2020

This comment has been minimized.

Sign in to view

akurinnoy reviewed Feb 10, 2020

View reviewed changes

dashboard/src/app/index.module.ts Outdated Show resolved Hide resolved

akurinnoy reviewed Feb 12, 2020

View reviewed changes

Improved messages for self-signed cert issues

133f582

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 force-pushed the CHE-15298 branch from ac1e654 to 133f582 Compare February 13, 2020 20:13

olexii4 added 2 commits February 14, 2020 11:50

fixup! Improved messages for self-signed cert issues

a567e87

fixup! Improved messages for self-signed cert issues

f3d4906

fixup! Improved messages for self-signed cert issues

86be300

akurinnoy approved these changes Feb 14, 2020

View reviewed changes

fixup! Improved messages for self-signed cert issues

3f770d7

olexii4 merged commit 24da259 into master Feb 14, 2020

olexii4 deleted the CHE-15298 branch February 14, 2020 17:13

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 14, 2020

che-bot added this to the 7.9.0 milestone Feb 14, 2020

sleshchenko mentioned this pull request Feb 17, 2020

Dashboard messages should be more accurate when self-signed cert issue happens #15298

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improved messages for self-signed cert issues #15951

Improved messages for self-signed cert issues #15951

olexii4 commented Feb 6, 2020 •

edited

Loading

che-bot commented Feb 6, 2020

che-bot commented Feb 6, 2020

che-bot commented Feb 6, 2020

che-bot commented Feb 6, 2020

che-bot commented Feb 6, 2020

sleshchenko commented Feb 6, 2020

This comment has been minimized.

sleshchenko commented Feb 6, 2020 •

edited by olexii4

Loading

che-bot commented Feb 6, 2020

beaumorley commented Feb 6, 2020 •

edited

Loading

che-bot commented Feb 6, 2020

olexii4 commented Feb 12, 2020

che-bot commented Feb 12, 2020

che-bot commented Feb 12, 2020

che-bot commented Feb 12, 2020

beaumorley commented Feb 12, 2020

beaumorley commented Feb 12, 2020

olexii4 commented Feb 13, 2020

che-bot commented Feb 13, 2020

che-bot commented Feb 13, 2020

che-bot commented Feb 14, 2020

che-bot commented Feb 14, 2020

che-bot commented Feb 14, 2020

che-bot commented Feb 14, 2020

olexii4 commented Feb 14, 2020

che-bot commented Feb 14, 2020

che-bot commented Feb 14, 2020

che-bot commented Feb 14, 2020

che-bot commented Feb 14, 2020

Improved messages for self-signed cert issues #15951

Improved messages for self-signed cert issues #15951

Conversation

olexii4 commented Feb 6, 2020 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

che-bot commented Feb 6, 2020

che-bot commented Feb 6, 2020

che-bot commented Feb 6, 2020

che-bot commented Feb 6, 2020

che-bot commented Feb 6, 2020

sleshchenko commented Feb 6, 2020

This comment has been minimized.

sleshchenko commented Feb 6, 2020 • edited by olexii4 Loading

che-bot commented Feb 6, 2020

beaumorley commented Feb 6, 2020 • edited Loading

che-bot commented Feb 6, 2020

olexii4 commented Feb 12, 2020

che-bot commented Feb 12, 2020

che-bot commented Feb 12, 2020

che-bot commented Feb 12, 2020

beaumorley commented Feb 12, 2020

beaumorley commented Feb 12, 2020

olexii4 commented Feb 13, 2020

che-bot commented Feb 13, 2020

che-bot commented Feb 13, 2020

che-bot commented Feb 14, 2020

che-bot commented Feb 14, 2020

che-bot commented Feb 14, 2020

che-bot commented Feb 14, 2020

olexii4 commented Feb 14, 2020

che-bot commented Feb 14, 2020

che-bot commented Feb 14, 2020

che-bot commented Feb 14, 2020

che-bot commented Feb 14, 2020

olexii4 commented Feb 6, 2020 •

edited

Loading

sleshchenko commented Feb 6, 2020 •

edited by olexii4

Loading

beaumorley commented Feb 6, 2020 •

edited

Loading