CODENVY-413: Make it possible to mark MachineNode as 'sheduled for maintenace' #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garagatyi review please |
| private List<File> files; | ||
| private String dockerfile; | ||
| private String remote; | ||
| private Boolean q; |
There was a problem hiding this comment.
it is not natural to have such a field in Java. Rename it to something meaningful
|
Build # 1191 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1191/ to view the results. |
mmorhun
force-pushed
the
CODENVY-413
branch
2 times, most recently
from
3d9b7f0
to
dd03b9d
Compare
mmorhun
changed the title
|
Build # 1200 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1200/ to view the results. |
|
LGTM |
|
@sleshchenko take a look please |
|
OK for me |
Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new parameters to build docker image method.