CHE-3209 add import and configure batch of projects on stack testing #3445
Conversation
| @@ -71,9 +71,10 @@ export class SelectTemplateController { | |||
| */ | |||
| startTest(): void { | |||
| let stack: che.IStack = angular.copy(this.stack); | |||
| /* tslint:disable */ | |||
There was a problem hiding this comment.
question: why do we need to disable tslint ?
There was a problem hiding this comment.
forbidden bitwise operation
https://github.com/eclipse/che/blob/master/dashboard/tslint.json#L46
| @@ -101,7 +103,16 @@ export class StackController { | |||
|
|
|||
| $window.addEventListener('message', (event: {data: string}) => { | |||
| if ('show-ide' === event.data) { | |||
| if (this.tmpWorkspaceId) { | |||
| //TODO remove this delay after fixing time of update tree | |||
There was a problem hiding this comment.
is there an open github issue ?
There was a problem hiding this comment.
Not yet. It is a time for project type update(from API). I should investigate it more.
| * @param index{number} - the index of the array of commands | ||
| * @param deferred{ng.IDeferred<any>} | ||
| */ | ||
| updateProjects(workspaceId: string, projects: Array<any>, index: number, deferred: ng.IDeferred<any>) { |
| while (iterations--) { | ||
| name = 'wksp-' + (('0000' + (Math.random() * Math.pow(36, 4) << 0).toString(36)).slice(-4)); // jshint ignore:line | ||
| if (!this.usedNamesList.indexOf(name) >= 0) { | ||
| /* tslint:disable */ |
There was a problem hiding this comment.
same question than before ?
There was a problem hiding this comment.
forbidden bitwise operation
https://github.com/eclipse/che/blob/master/dashboard/tslint.json#L46
|
Build # 1401 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1401/ to view the results. |
olexii4
force-pushed
the
CHE-3209
branch
2 times, most recently
from
377da41 to
fe273a0
Compare
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1510/ |
Signed-off-by: Oleksii Orel <oorel@codenvy.com>
Signed-off-by: Oleksii Orel <oorel@codenvy.com>
Signed-off-by: Oleksii Orel <oorel@codenvy.com>
slemeur
added
the
kind/enhancement
CHE-3209 add import and configure batch of projects on stack testing
What does this PR do?
Add import and configure batch of projects on stack testing
What issues does this PR fix or reference?
#3209
Signed-off-by: Oleksii Orel oorel@codenvy.com