Do not fetch runtimes when getting list of all workspaces #3557
Conversation
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1478/ |
mkuznyetsov
force-pushed
the
che-3082
branch
from
d465700 to
517bc12
Compare
| * ID of requested workspace | ||
| * @return workspace status | ||
| */ | ||
| public WorkspaceStatus getStatus(String workspaceId) { |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1488/ |
|
Build # 1507 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1507/ to view the results. |
|
Build # 1524 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1524/ to view the results. |
|
Now returns workspace status |
| @@ -1046,7 +1046,7 @@ export class CreateProjectController { | |||
| * @param workspace existing workspace | |||
| */ | |||
| checkExistingWorkspaceState(workspace: any): void { | |||
| if (workspace.runtime) { | |||
| if (workspace.status === 'RUNNING') { | |||
There was a problem hiding this comment.
if (workspace.status === 'RUNNING')is not the same to
if (workspace.runtime)it looks like
if (workspace.status !== 'STOPPED')is the correct option here
There was a problem hiding this comment.
'RUNNING' is fine here, cause wait for this status to start importing projects
|
@ashumilova please review client-side changes |
|
Build # 1535 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1535/ to view the results. |
|
Build # 1540 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1540/ to view the results. |
|
same logic done for WorkspaceService#getByNamespace() |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1564/ |
slemeur
added
the
kind/bug
…e#3557) * Do not fetch runtimes when getting list of all workspaces
* Do not fetch runtimes when getting list of all workspaces
What does this PR do?
Removes getting workspace runtimes info on 'get all workspaces' service
What issues does this PR fix or reference?
#3082