CODENVY-1506 Rework workspace manager methods to optionally return runtime info #3714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 12, 2017 18:08
Conflicts: wsmaster/che-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/jpa/JpaWorkspaceDao.java
mkuznyetsov
changed the title
sleshchenko
reviewed
Jan 13, 2017
| requireNonNull(namespace, "Required non-null namespace"); | ||
| final List<WorkspaceImpl> workspaces = workspaceDao.getByNamespace(namespace); | ||
| for (WorkspaceImpl workspace : workspaces) { | ||
| normalizeState(workspace); | ||
| if (includeRuntimes) { |
There was a problem hiding this comment.
Would be logic the same if you rewrite code as
for (WorkspaceImpl workspace : workspaces) {
normalizeState(workspace, includeRuntimes);
}
?
garagatyi
reviewed
Jan 13, 2017
| requireNonNull(user, "Required non-null user id"); | ||
| final List<WorkspaceImpl> workspaces = workspaceDao.getWorkspaces(user); | ||
| for (WorkspaceImpl workspace : workspaces) { | ||
| workspace.setStatus(runtimes.getStatus(workspace.getId())); | ||
| if (includeRuntimes) { |
There was a problem hiding this comment.
garagatyi
approved these changes
Jan 13, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1616/ |
sleshchenko
approved these changes
Jan 13, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1640/ |
skabashnyuk
approved these changes
Jan 16, 2017
|
Build # 1644 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1644/ to view the results. |
slemeur
added
the
kind/bug
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Methods getWorkspaces and getByNamespace now have boolead parameter which indicates whether to fetch runtimes or not
What issues does this PR fix or reference?
codenvy/codenvy#1506