Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHE-3620:Remove MachineServiceClient and related classes #3963

Merged
merged 6 commits into from
Mar 7, 2017
Merged

CHE-3620:Remove MachineServiceClient and related classes #3963

merged 6 commits into from
Mar 7, 2017

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Jan 31, 2017 •
edited by bmicklea
Loading

We don't use Machine API anymore. We should remove client in IDE since it is additional technical debt for maintainers.
Issue supposes:

  • remove machine creation/destroying API
  • remove machine exec's API
  • remove workarounds added to continue support of machine API

#3620

Changelog

Removed Machine client side API (was deprecated in 5.2).

Release Notes

(covered by the release notes section from #4331)

CHE-3620:Remove MachineServiceClient and related classes
a0cd37c 
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
@vparfonov vparfonov self-assigned this Jan 31, 2017
@vparfonov vparfonov added kind/enhancement A feature request - must adhere to the feature request template. sprint/next team/ide labels Jan 31, 2017
@vparfonov vparfonov added this to the 5.3.0 milestone Jan 31, 2017
@TylerJewell
Copy link

Missing changelog, release notes and docs reference

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1825/

@vparfonov vparfonov removed this from the 5.3.0 milestone Feb 13, 2017
@codenvy-ci
Copy link

Build finished.
Build success. $BUILD_URL

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2089/

@skabashnyuk skabashnyuk added this to the 5.5.0 milestone Mar 2, 2017
@codenvy-ci
Copy link

Build finished.
Build success. $BUILD_URL

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2090/

@JamesDrummond
Copy link
Contributor

Did we notify users of deprecation if this is a deprecation? I thought we added this to our documentation but we discussed https://github.com/eclipse/che/wiki/Minutes:-February-14,-2017

@codenvy-ci
Copy link

Build finished.
Build # 2110 - FAILED

Please check console output at $BUILD_URL to view the results.

@codenvy-ci
Copy link

Build # 2110 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2110/ to view the results.

@codenvy-ci
Copy link

Build finished.
Build # 2116 - FAILED

Please check console output at $BUILD_URL to view the results.

@codenvy-ci
Copy link

Build # 2116 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2116/ to view the results.

@mshaposhnik
Copy link
Contributor

@codenvy/pm pls approve

@mshaposhnik mshaposhnik merged commit 0951e40 into master Mar 7, 2017
@mshaposhnik mshaposhnik deleted the che#3620 branch March 7, 2017 14:36
@JamesDrummond JamesDrummond mentioned this pull request Mar 17, 2017
Closed
9 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
@mshaposhnik
CHE-3620:Remove MachineServiceClient and related classes (eclipse-che…
4197c8b 
…#3963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmicklea bmicklea bmicklea approved these changes

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@JamesDrummond JamesDrummond Awaiting requested review from JamesDrummond

Assignees

@vparfonov vparfonov

Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
7 participants
@vparfonov @TylerJewell @codenvy-ci @JamesDrummond @mshaposhnik @skabashnyuk @bmicklea