Don't create a snapshot if agent lost connection #4325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhukovs
added
kind/bug
|
Build finished. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2111/ |
vparfonov
reviewed
Mar 7, 2017
| @@ -204,8 +198,8 @@ private void started() { | |||
| private void checkStateOfWsAgent(WsAgentHealthStateDto agentHealthStateDto) { | |||
| final int statusCode = agentHealthStateDto.getCode(); | |||
| final String infoWindowTitle = "Workspace Agent Not Responding"; | |||
| final ConfirmCallback stopCallback = new StopCallback(false); | |||
| final ConfirmCallback stopAndReloadCallback = new StopCallback(true); | |||
| final ConfirmCallback stopCallback = new StopCallback(false, true); | |||
There was a problem hiding this comment.
add named variable, because hard to understand StopCallback(false, true)
|
Build finished. Please check console output at $BUILD_URL to view the results. |
|
Build # 2132 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2132/ to view the results. |
Signed-off-by: Vladyslav Zhukovskii <vzhukovskii@codenvy.com>
|
ci-build |
|
QA didn't reveal any regressions |
vparfonov
reviewed
Mar 9, 2017
| @@ -69,7 +69,7 @@ | |||
| private final WorkspaceServiceClient workspaceServiceClient; | |||
| private final LoaderPresenter loader; | |||
| //not used now added it for future if it we will have possibility check that service available for client call | |||
| private final List<RestServiceInfo> availableServices; | |||
| private final List<RestServiceInfo> availableServices; //TODO do we really need this variable? | |||
There was a problem hiding this comment.
You can remove this variable
vparfonov
approved these changes
Mar 9, 2017
Signed-off-by: Vladyslav Zhukovskii <vzhukovskii@codenvy.com>
|
Build finished. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2149/ |
vzhukovs
added
severity/P2
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* Don't create a snapshot if agent lost connection Signed-off-by: Vladyslav Zhukovskii <vzhukovskii@codenvy.com> * Delete redundant code Signed-off-by: Vladyslav Zhukovskii <vzhukovskii@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Disable creating a snapshot in case if workspace agent lost connection.
When workspace agent loses connection, we currently allow user to reload entire page to allow Che to restore web socket connections. Sometimes, during the restart Che could create a snapshot for a while. So this PR propose to disable snapshot creating and instant instance reloading.
What issues does this PR fix or reference?
#3805
Changelog
Disable creating a snapshot in case if workspace agent lost connection.
Release Notes
Disable creating a snapshot in case if workspace agent lost connection.
Docs PR
N/A