CHE-3616 Remove Machine API (server part) #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
mshaposhnik
added
the
kind/task
|
The plan is to merge this for 5.5, correct? (I need to know as it affects the release notes). |
|
@bmicklea yes |
bmicklea
approved these changes
Mar 6, 2017
|
Build finished. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2119/ |
garagatyi
approved these changes
Mar 7, 2017
| @@ -85,12 +82,14 @@ protected void configure() { | |||
| devMachineVolumes.addBinding().toProvider(org.eclipse.che.plugin.docker.machine.ext.provider.ExtraVolumeProvider.class); | |||
|
|
|||
| Multibinder<Set<String>> networks = Multibinder.newSetBinder(binder(), | |||
| new TypeLiteral<Set<String>>() {}, | |||
There was a problem hiding this comment.
Please do not change formatting here and there unless you have strong opinion on that
|
Build finished. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2123/ |
skabashnyuk
approved these changes
Mar 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use Machine API anymore. We should remove server side logic.
Issue supposes:
#3616
Changelog
The Machine API has been removed in this release.
Release Notes
[in the advisory section]
Machine API Removed: The Machine API was deprecated in Codenvy 5.2 and is removed in 5.5. Please use the Workspace API as a replacement.