Frequent 'Unable to initialize IDE' error on AWS #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the logic for injecting the Orion editor from the OrionEditorExtension class to the EditorInitializerPromiseHolder. Thus avoiding the chance for having the initializePromise field with null value.
If injected multiple times, eventually, the last one may be injected *after* the orion-codenvy-theme.css stylesheet. Thus causing issues to theming the code editor.
|
Can one of the admins verify this patch? |
TylerJewell
added
kind/bug
|
This would be a huge find and fix. @kaloyan-raev - did you commit with the right email address that has a CLA? |
|
I think I forgot to hit the sign-off button... Let me check if I can simply amend another commit with the sign-off. |
Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
|
I've asked Vitalii and Dmitry Kuleshov to do a review of this in the next sprint. I think this is something that we should not wait on. |
dkulieshov
approved these changes
Mar 9, 2017
evidolob
approved these changes
Mar 9, 2017
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* CHE-4288: Frequent 'Unable to initialize IDE' error on AWS Move the logic for injecting the Orion editor from the OrionEditorExtension class to the EditorInitializerPromiseHolder. Thus avoiding the chance for having the initializePromise field with null value. * Ensure built-codeEdit.css is injected only once If injected multiple times, eventually, the last one may be injected *after* the orion-codenvy-theme.css stylesheet. Thus causing issues to theming the code editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue with the 'Unable to initialize IDE' error when loading the Web IDE.
The issue is caused by a race condition. The
LanguageServerFileTypeRegister.start()method might be called before the call to theOrionEditorExtensionconstructor. Thus when the execution reaches theEditorInitializePromiseHolder.getInitializerPromise()method, theinitializerPromiseis stillnullthrowing a RuntimeException and failing the Web IDE initialization.The PR refactors the code to avoid this situation.
What issues does this PR fix or reference?
Frequent 'Unable to initialize IDE' error on AWS #4288
Changelog
Fixed issue with an 'Unable to initialize IDE' error when loading the Web IDE.
Release Notes
N/A
Docs PR
N/A
Signed-off-by: Kaloyan Raev kaloyan.r@zend.com