Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "CHE-120 Workspace creation as non-privileged container. Movin… #4390

Merged

Conversation

l0rd
Copy link
Contributor

@l0rd l0rd commented Mar 10, 2017

The PR was still work in progress when I've merged it. Let's revert it since it broke creating a simple java workspace.

Changelog

Revert CHE-120 Workspace creation as non-privileged container.

…g instructions for '/project' dir creation and package installation from ws-agent script to Dockerfile."

This reverts commit 2580099.

Signed-off-by: Mario Loriedo <mloriedo@redhat.com>
@l0rd l0rd force-pushed the revert-unprivileged-commit branch from 9d1353a to 652c42a Compare March 10, 2017 12:47
@l0rd l0rd requested a review from ibuziuk March 10, 2017 12:48
@codenvy-ci
Copy link

Can one of the admins verify this patch?

@ibuziuk
Copy link
Member

ibuziuk commented Mar 10, 2017

@l0rd It was decided not to have stacks.json.centos and just update original one, right ?

@l0rd
Copy link
Contributor Author

l0rd commented Mar 10, 2017

@ibuziuk correct

@ibuziuk ibuziuk merged commit 652c42a into eclipse-che:openshift-connector Mar 10, 2017
@JamesDrummond JamesDrummond added this to the 5.5.0 milestone Mar 17, 2017
@JamesDrummond JamesDrummond mentioned this pull request Mar 17, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants