#4554 fix Class not found exception in maven server #4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Even Vidolob <evidolob@codenvy.com>
skabashnyuk
reviewed
Mar 29, 2017
| } catch (ArtifactResolutionException e) { | ||
| MavenServerContext.getLogger().info(e); | ||
| } catch (ArtifactResolutionException ignored) { | ||
| //we need ignore exception, it's some times has class that client doesn't has |
There was a problem hiding this comment.
may be system.error.println()?
There was a problem hiding this comment.
All sdtout/stderr of the maven sever is logged by client, but 'ArtifactResolutionException' is normal when maven can't find or download artifact, so I not sure that this exception need to be logged.
vparfonov
approved these changes
Mar 29, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2312/ |
dmytro-ndp
approved these changes
Mar 30, 2017
gazarenkov
added
the
kind/bug
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…se-che#4613) Signed-off-by: Even Vidolob <evidolob@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
ClassNotFoundExceptionwhen download maven artifact sources.What issues does this PR fix or reference?
#4554