Fix fetch user return promise #4695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashumilova
added
the
kind/enhancement
akurinnoy
approved these changes
Apr 4, 2017
benoitf
reviewed
Apr 4, 2017
| @@ -373,11 +373,15 @@ export class CheUser { | |||
| fetchUser(): ng.IPromise<any> { | |||
| let promise = this.remoteUserAPI.get().$promise; | |||
| // check if if was OK or not | |||
| promise.then((user: che.IUser) => { | |||
| return promise.then((user: any) => { | |||
There was a problem hiding this comment.
user is no longer of che.IUser type ?
There was a problem hiding this comment.
no, my mistake - fixed
Signed-off-by: Ann Shumilova <ashumilova@codenvy.com>
ashumilova
force-pushed
the
fix_fetch_user
branch
from
b4efe2f to
fe6efd4
Compare
benoitf
approved these changes
Apr 4, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2378/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ann Shumilova ashumilova@codenvy.com
What does this PR do?
Reworks fetch current user to return promise and handle 304.
Changelog
[UD] reworked fetch current user to return promise on error and handle 304 status properly.
Release Notes
N/A
Docs PR
N/A