Wrong completion text for AnonymousDeclarationType

[Eskibear]

Originally reported in microsoft/vscode-java-pack#203 , the snippet string for the completion item is wrong.

Before

public class A {
  void foo() {
    new IA<-------- Trigger completion here
  }
}

interface IA {
  void bar();
}

After

public class A {
  void foo() {
    new IA(){
      @Override
      public void bar() {
        ${0// TODO Auto-generated method stub
        }
      }
    };
  }
}

interface IA {
  void bar();
}

LSP request/response

[Trace - 上午10:29:32] Sending request 'completionItem/resolve - (2786)'.
Params: {
    "label": "IA()  Anonymous Inner Type",
    "detail": "com.example.demo",
    "insertTextFormat": 1,
    "insertText": "IA",
    "kind": 4,
    "sortText": "999999100",
    "data": {
        "decl_signature": "Lcom.example.demo.IA;",
        "pid": "0",
        "rid": "43",
        "uri": "file:///C:/Users/yanzh/Desktop/play/demo/src/main/java/com/example/demo/A.java"
    }
}


[Trace - 上午10:29:32] Received response 'completionItem/resolve - (2786)' in 16ms.
Result: {
    "label": "IA()  Anonymous Inner Type",
    "kind": 4,
    "detail": "com.example.demo",
    "sortText": "999999100",
    "insertText": "IA",
    "insertTextFormat": 2,
    "textEdit": {
        "range": {
            "start": {
                "line": 7,
                "character": 8
            },
            "end": {
                "line": 7,
                "character": 10
            }
        },
        "newText": "IA(){\r\n\r\n\t@Override\r\n\tpublic void bar() {\r\n\t\t${0// TODO Auto-generated method stub\r\n\t\t}\r\n\t}\n};"
    }
}

[Eskibear]

Root cause

Missing semicolon in snippet string. In jdt.core.manipulation, a corner case is not coverred (possibly due to upstream refactoring):

• bodyStatement is empty but bodyContent is not, because of additional auto-generated comments

See: https://github.com/eclipse/eclipse.jdt.ui/blob/c554aedb07125de381956149030d24ff23e7e4ce/org.eclipse.jdt.core.manipulation/core%20extension/org/eclipse/jdt/internal/corext/codemanipulation/StubUtility2Core.java#L398-L414

Solution

• Fix upstream issue #550877
• PR Fix anonymous declaration type completion #1169 Update corresponding test cases, e.g.