Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quickfix for remove final modifier #441

Closed
fbricon opened this issue Nov 17, 2017 · 2 comments · Fixed by #1324
Closed

Add quickfix for remove final modifier #441

fbricon opened this issue Nov 17, 2017 · 2 comments · Fixed by #1324
Labels
code-actions enhancement
Milestone
Mid February 2020

Comments

@fbricon
Copy link
Contributor

fbricon commented Nov 17, 2017

Handle the following cases in QuickFixProcessor:

case IProblem.NonBlankFinalLocalAssignment:
case IProblem.DuplicateFinalLocalInitialization:
case IProblem.FinalFieldAssignment:
case IProblem.DuplicateBlankFinalFieldInitialization:
case IProblem.AnonymousClassCannotExtendFinalClass:
case IProblem.ClassExtendFinalClass:
    ModifierCorrectionSubProcessor.addNonAccessibleReferenceProposal(context,problem, proposals, 
    ModifierCorrectionSubProcessor.TO_NON_FINAL, IProposalRelevance.REMOVE_FINAL_MODIFIER);
@fbricon
Copy link
Contributor Author

fbricon commented Jan 15, 2020

@NikolasKomonen can you take a look please?

@NikolasKomonen
Copy link
Contributor

No problem, on it.

NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this issue Jan 24, 2020
@NikolasKomonen
Implemented quickfix removals code action Fixes eclipse-jdtls#441
a9831c7 
Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this issue Jan 24, 2020
@NikolasKomonen
Implemented quickfix removals code action Fixes eclipse-jdtls#441
3debe1f 
Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this issue Jan 24, 2020
@NikolasKomonen
Implemented quickfix removals code action Fixes eclipse-jdtls#441
969231a 
Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
@NikolasKomonen NikolasKomonen mentioned this issue Jan 24, 2020
Merged
NikolasKomonen added a commit to NikolasKomonen/eclipse.jdt.ls that referenced this issue Jan 24, 2020
@NikolasKomonen
Implemented quickfix removals code action Fixes eclipse-jdtls#441
1dc599e 
Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
@fbricon fbricon added this to the Mid January 2020 milestone Jan 25, 2020
fbricon pushed a commit that referenced this issue Jan 25, 2020
@NikolasKomonen @fbricon
"Remove 'final' modifier" code actions
2aa45af 
Fixes #441

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-actions enhancement
Projects
None yet
Milestone
Mid February 2020
Development

Successfully merging a pull request may close this issue.

"Remove 'final' modifier" code actions NikolasKomonen/eclipse.jdt.ls
2 participants
@fbricon @NikolasKomonen