Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elk.mrtree edges behave weird with identical labels in different child nodes #1072

Open
YorikHansen opened this issue Aug 29, 2024 · 3 comments
Labels
bug Erroneous behaviour.
Milestone

Comments

@YorikHansen
Copy link

YorikHansen commented Aug 29, 2024

Describe the bug
When child nodes have identical labels, the edges are not properly layouted. This includes:

  1. edges starting from the east side of the node even though they should start on the south,
  2. outgoing edges not being justified properly and
  3. incoming edges that enter a node in an unexpected angle.

See an example

Expected behavior
The tree is drawn in the same way it would be if the labels weren't identical or not existing at all.

Screenshots
grafik

ELK Version
0.9.1 (and all other versions) and the current snapshot.

Additional context
Add any other context about the problem here.

@YorikHansen YorikHansen added the bug Erroneous behaviour. label Aug 29, 2024
@soerendomroes
Copy link
Contributor

It seems to depend on the actual labels in there. Interestingly this works.

@soerendomroes
Copy link
Contributor

Here is a smaller example.

@soerendomroes soerendomroes added this to the Release 0.9.2 milestone Sep 6, 2024
@YorikHansen YorikHansen changed the title elk.mrtree edges behave weird with short labels in nodes elk.mrtree edges behave weird with identical labels in different child nodes Sep 22, 2024
@YorikHansen
Copy link
Author

It seems to have nothing to do with the length of the label but with the fact that they are identical for both children. This example with long node labels is also affected.

Therefore I changed the title and description of the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Erroneous behaviour.
Projects
None yet
Development

No branches or pull requests

2 participants