Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Reworked Dockerfile #566

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Reworked Dockerfile #566

merged 2 commits into from
Oct 26, 2020

Conversation

jponge
Copy link
Contributor

@jponge jponge commented Oct 25, 2020

No description provided.

@jponge jponge added this to the 3.4.0 milestone Oct 25, 2020
@jponge jponge requested review from k33g and yloiseau October 25, 2020 09:45
Copy link
Contributor

@k33g k33g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🧹🐳

Dockerfile Outdated
rm -rf /src /root/.gradle
FROM azul/zulu-openjdk-alpine:8
COPY --from=builder /src/build/install/golo /opt/golo
RUN ln -s /opt/golo/bin/golo /usr/bin/golo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you add to PATHs instead of symlink ?

  • /opt/golo/man into MANPATH
  • /opt/golo/bin and maybe /opt/golo/share/shell-completion/ into PATH
  • maybe opt/golo/lib/*.jar to CLASSPATH

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@jponge jponge merged commit ea4526e into master Oct 26, 2020
@yloiseau yloiseau deleted the feature/dockerfile-rework branch December 1, 2020 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants