Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDI supports SHA256 #869

Merged
merged 4 commits into from
Jul 29, 2019
Merged

DDI supports SHA256 #869

merged 4 commits into from
Jul 29, 2019

Conversation

dobleralex
Copy link
Contributor

@dobleralex dobleralex commented Jul 18, 2019 •
edited
Loading

Adds SHA 256 hash to output of:

GET /{tenant}/controller/v1/{controllerid}/deploymentBase/{actionId}
GET /{tenant}/controller/v1/{controllerid}/softwaremodules/{softwareModuleId}/artifacts

Example response:

{
  "id" : "4",
  "deployment" : {
    "download" : "forced",
    "update" : "forced",
    "maintenanceWindow" : "available",
    "chunks" : [ {
      "part" : "jvm",
      "version" : "1.0.15",
      "name" : "oneapp runtime",
      "artifacts" : [ {
        "filename" : "binary.tgz",
        "hashes" : {
          "sha1" : "8b71973e835cd0718827238b1cf89f0079e44dae",
          "md5" : "a90218782025c48e09ba0436cf30d029",
          "sha256" : "77837523c5aed7d5e80738baea1f4b768bb776e8a9345bc1bf8d1b7944f2b8cb"
        }, 
...
}

dobleralex added 3 commits July 4, 2019 11:14
@dobleralex
Add SHA256 file hash to ddi GET outputs
787df96 
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>
@dobleralex
Integrate review findings for SHA256 changes
eaa1fa9 
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>
@dobleralex
Renamed hashes to base16hases in store() parameters
26892d2 
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>
@schabdo schabdo added this to the 0.3.0M5 milestone Jul 18, 2019
@dobleralex dobleralex mentioned this pull request Jul 18, 2019
Merged
@dobleralex
Added missing javadoc according to sonarqube findings
9e8b6cb 
Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>
@schabdo schabdo merged commit bde3548 into eclipse-hawkbit:master Jul 29, 2019
@schabdo schabdo deleted the feature_ddi_sha256_support branch July 29, 2019 12:11
@schabdo schabdo changed the title Feature ddi sha256 support DDI supports SHA256 Jul 29, 2019
AmmarBikic pushed a commit to bosch-io/hawkbit that referenced this pull request Oct 2, 2020
@dobleralex
DDI supports sha256 (eclipse-hawkbit#869)
b531500 
* Add SHA256 file hash to ddi GET outputs

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Integrate review findings for SHA256 changes

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Renamed hashes to base16hases in store() parameters

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>

* Added missing javadoc according to sonarqube findings

Signed-off-by: Alexander Dobler <alexander.dobler3@bosch-si.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
0.3.0M5
Development

Successfully merging this pull request may close these issues.
2 participants
@dobleralex @schabdo