Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new DMF message THING_REMOVED #891

Merged
merged 5 commits into from
Oct 10, 2019

Conversation

Nkyn
Copy link
Contributor

@Nkyn Nkyn commented Sep 30, 2019

Introduce new DMF message THING_REMOVED to request target deletion as a client.
Signed-off-by: Natalia Kislicyn natalia.kislicyn@bosch-si.com

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
@Nkyn Nkyn marked this pull request as ready for review September 30, 2019 09:06
@schabdo schabdo added this to the 0.3.0M6 milestone Sep 30, 2019
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
Copy link
Contributor

@bogdan-bondar bogdan-bondar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
@schabdo schabdo merged commit 1936032 into eclipse-hawkbit:master Oct 10, 2019
@schabdo schabdo deleted the feature_thing_deletion_dmf branch October 10, 2019 12:41
AmmarBikic pushed a commit to bosch-io/hawkbit that referenced this pull request Oct 2, 2020
* Introduce new DMF message THING_REMOVED

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* rename test to its original name

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* API documentation adapted; constant defined for duplicated string

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* Resolve review comments; Replace try/catch blocks in exceptions testing

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>

* Re-add finally block in test cases

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants