-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new DMF message THING_REMOVED #891
Merged
schabdo
merged 5 commits into
eclipse-hawkbit:master
from
bosch-io:feature_thing_deletion_dmf
Oct 10, 2019
Merged
Introduce new DMF message THING_REMOVED #891
schabdo
merged 5 commits into
eclipse-hawkbit:master
from
bosch-io:feature_thing_deletion_dmf
Oct 10, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
Nkyn
commented
Sep 30, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java
Show resolved
Hide resolved
Nkyn
commented
Sep 30, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
bogdan-bondar
requested changes
Oct 7, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaControllerManagement.java
Outdated
Show resolved
Hide resolved
...f/hawkbit-dmf-amqp/src/test/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerServiceTest.java
Outdated
Show resolved
Hide resolved
...f/hawkbit-dmf-amqp/src/test/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerServiceTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
bogdan-bondar
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
schabdo
reviewed
Oct 10, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/ControllerManagementTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
AmmarBikic
pushed a commit
to bosch-io/hawkbit
that referenced
this pull request
Oct 2, 2020
* Introduce new DMF message THING_REMOVED Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com> * rename test to its original name Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com> * API documentation adapted; constant defined for duplicated string Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com> * Resolve review comments; Replace try/catch blocks in exceptions testing Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com> * Re-add finally block in test cases Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new DMF message THING_REMOVED to request target deletion as a client.
Signed-off-by: Natalia Kislicyn natalia.kislicyn@bosch-si.com