-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated Hawkbit UI to Vaadin 8 #980
Merged
laverman
merged 25 commits into
eclipse-hawkbit:master
from
bosch-io:feature_migration_to_vaadin_8_final
Aug 21, 2020
Merged
Migrated Hawkbit UI to Vaadin 8 #980
laverman
merged 25 commits into
eclipse-hawkbit:master
from
bosch-io:feature_migration_to_vaadin_8_final
Aug 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed tag assignment messages * disable rollout buttons instead of hinding them in Rollout Grid * fix mssql db error * small improvements to remove duplications while creating labels and distribution set type combo * upgraded Vaadin to 8.11.1, upgraded jsoup to 1.11.2 (used by Vaadin 8.11.1), fixed selection in Metadata window, moved Rollout Window components to separate components package * moved DS/SM type combobox creation to FormComponentBuilder, fixed add to collection error in SoftwareModuleDetails, changed save entity icons to harddrive, common refactoring * removed duplications between breadcrumb grid headers (RolloutGroupGridHeader, RolloutGroupTargetGridHeader, TargetFilterDetailsGridHeader) * replace proxy type in proxy objects with simple type info * made all text fileds lazy (the timeout is 500ms), fixed add rollout window error on getting the bean from layout to controller * removed duplications between ds to tag and target to tag assignment supports, extracted assignment notification from HawkbitCommonUtils * fixed search input with caption overlap * refactored layout visibility and resize listeners * fixed approval strategy, adapted rollout advanced group ids to always increase * Combine created and modified column creation * remove Column<?, ?> variables * fix confirmation dialog line breaks * fix grids in details and filters * fix column creation for upload grids * add default ExpandRatio, fix rollouts and target filter * add default addColumn method and fix action grids * update deployment and rollout grid and grid css * fix grid column widths * refactored approval layout * adapted approval layout * refactored advanced rollout group layout * refactored advanced group definitions to use proxy bean * fixed copy rollout window enable save button * third draft of Rollout Window validation: added UNKNOWN validation status, validate all layouts after validation listener is added * second draft of Rollout Window Validation * first Rollout Window Validation draft for enable/disable save button * fixed custom target filter de-selection on delete, re-selection on update, reset edit/delete crud menu mode on custom filter tab selection * added error threshold validation on total target and number of groups change * added random ids to Proxy identifiable entities without defined ids * add universal check box generator * adapted Update and Approve Rollout Window Layout * adapted setting and getting bean values for Add and Copy Rollout layouts * fix setting ConfirmationDialog ID * refactor ConfirmationDialog to use a CommonDialogWindow internally * fix rollout group definition input width * remove code duplication in UI grid column creation * refactored rollout group pie chart and legend by extracing them to their own class VisualGroupDefinitionLayout * remove code duplication on link creation * moved creation of AutoStartOptionGroupLayout to FormComponentBuilder * extracted RolloutFormLayout and SimpleGroupsLayout together with corresponding proxy beans from AddRolloutWindowLayout, adapted code accordingly * move TimeforcedIcon generation to StatusIconBuilder * move code to StatusIconBuilder * use objects to build labels from entity states * use generic method to generate status icon labels * moved AdvancedGroupRow from DefineGroupsLayout to separate class * remove code duplication on icon creation * removed Optionals from Data Providers * fixed remaining parts of xss vulnarable components (tags/types) * added description to key-value details pairs, moved the logic of paginated database access to HawkbitCommonUtils * further adapted xss atack posibilities * adapted details header and key-value details * adapted MetaData header * adapted Artifact and Action History Grid headers * adapted artifact download * adapted already assigned notification and rollout approval permission check * removed tenant and username cookies from hawkbit login * adapted attributes sorting by key * adapted controller attributes details * removed grid ResizeSupport (can be introduced later if needed) * refactored grids to not use resizeSupport but rather removing all columns and re-adding them after max/min state transition * fixed selection of added items * moved restoreState to AbstractGrid * unified Ds grids on Distribution and Deployment Views * moved filter support and drag and drop support to AbstractGrid * removed stale Sm grid id for Upload view * removed duplication between SwModuleGrid and SoftwareModuleGrid * removed unneccessary status icons css properties * added grid MasterEntitySupport, adapted grids * fixed tags/types filter deselection after deletion * fixed deletion success notification, added artifact uploads count check to software module table * unified target/ds/sm grid headers * unified DS and SM grid headers and details * added Delete Support to Rollout, adapted deletion permissions * introduced EntityResizeSupport, upgraded vaadin version to 8.10.4 * unified ds and sm type filter components * removed duplications between Target and Ds tag filters * removed duplication for #buildActionButton * initial iteration of removing duplications between grids * added GridActionsVisibilityListener * added layout visibility listener to filter and rollout views * unified LayoutResizeListener and LayoutVisibilityListener * extracted ShowEntityFormLayoutListener * refactored grid filter listeners * refactored target filter listeners, introduced filter support * added GenericEventListener, further unified listeners * partially unified LayoutViewAware event listeners, added PinningChangedListener, TagFilterListener and TypeFilterListener * fixed sql exception in case NO_TAG is selected without any additional tags active * unified entity modified listeners, adapted tag token modified update * fixed Upload View drop area enable on SM select * unified selection listeners * unified search listeners * added common SearchFilterListener, added temporare EntityModifiedMasterAwareSupport for EntityModifiedListener, fixed Rollout View change after rollout deletion/modification, adapted state restore * refactored entity modified and selection listeners together with support classes * added maintenance window and created/modified at tooltips in Action History Window, added id to Bulk Upload popup window and main popup layout, fixed duplicated DS error during DS edit/update * substituted ShowEntityDetailsEventPayload with SelectionChangedEventPayload in Rollout View for consistency with other Views, unified rollout ui state class * added builder to EntityModifiedListener, adapted code * refactored sm type modification of ds type * fix removing sm type from ds type via ui * refresh rollout group targets table on group-updated-event * moved grid label icon creation to SpUiComponent builder * fixed edit tag/type with invalid colour * added range validator(0-100) to trigger threshold * fixed rollout auto start option updates, fixed rollout grid search state restore, extended SPDateTimeUtil * Rollout Window Form fixes * small partial fix for error threshold percent/count validation and value change * fixed time forced empty datetime in Rollouts Update Window * added workaround for target/ds tags drag and drop due to the missing selection support * fixed ds unpinning after deletion and completion state change * added reason to bulk upload failed notification * fixed target add/update window form name id, introduced separate layout listeners for entity modified events and selection/master changed events, extended grid selection support, refactored corresponding grids, layouts and listeners * fixed required messages in the from builder, changed asyncExecutor to ui executor for file streaming, fixed auto-assignment for layout * fixed drag and drop registration for non-selection grid model, small restore state refactoring * fixed action remote events tests, adapted crudMenu/resize/search header supports to use mode-{mode} classes instead of ids modification * changed id of metadata popup grid to 'metadata.window.table.id' and details grid to '{typePrefix}.metadata.details.table.id', fixed tag/type cell text wrapping, tooltip shows full tag/type name, removed checkboxes from Distributions Set Type Software module selection grids * added tooltip to Rollout/RolloutGroup status bar, small bug fixes for Rollout Window target filter and approval * fixed edit permission validation in DetailsHeader * unbind distributionsview javascript from vaadin theme * small refactoring of form component builder, assignment and rollout layout * remove ds combobox code duplication, fix assig and autoassign popup * add BoundComponent class, fix assignment popup * remove duplicates for name, version description and actiontype fields * removed code duplication, fix assign- and autoassign-popup * adapted Action history eventing, changed entity modified parent event propagation * added id to DS details modules grid * started adapting Action History View * adapted filter by ds drop area restore * align drop styling with previous * fix filter target table by assigned ds * small refactoring of Deployment View and System config View layouts * adapted DS tag layout * fixed incompelete DS deselection and unpinning * added filter to RemoteEventListener in order to ignore remote events, added select entity on add to grids * fixed DS modules details, explained why session scope is used for bulk upload * adapted bulk upload window to be lazy loaded, fixed restore by usinng session scope * fixed user cell text selection in grid, drop hint highlighting * fixed undo for iot-update-server config option * fixed parsing in DurationField and refactored system config view * removed unused variable from DurationField * refactored config option view * fixed polling option value in config option view * fixed token refresh value in config option view * added binder auth config option * added binder to save config option * added binder for auto cleanup option * upgraded vaadin to 8.10.0, removed dd package together with CustomAcceptCriteria extension, removed CustomAcceptCriteria tests, removed all vaadin v7 dependencies, removed compatibility server and client * added selection by pressing key up/down, refactored range selection handler and connector, drag and drop support drop style listener, removed unneccessary styles for selection extension * show drop hint * fix h2 cast error * make unselected row dragable * add support for selection using Shift and CTRL * remove grid checkboxes, fix selection and drag and drop * moved bulk upload classes to own package, started implementing bulk upload window builder * further adaptations of bulk upload * started adapting bulk upload * partially removed stale classes/methods, vaadin v7 imports * completeted pinning refactoring * further pinning refactoring, added restore to distributions grid in deployment view * started adapting pinning of target and distribution set * further remote eventing refactoring, small styling adaptations * added 'maximize' and 'minimize' ids to max/min grid icons * removed event containers, adapting the delayed event bus push strategy, event provider and remote events listener * small eventing refactoring * adapted tag filter eventing, removed old event classes * adapted selection eventing, fixed color styling for grid selection, added countByAssignedId to softwaremodulemanagement * adapted type filter eventing * adapted search filter eventing * adapted actions visibility change eventing in filter layouts * adapted layout eventing in Deployment View * adapted layout eventing in Distributions View * adapted layout eventing in Upload View * adapted entity modified eventing * adapted rollout eventing * fix rollout view and window styling * handle rollouts view remote events * adapted eventing in Rollouts View * fixed Target Filter session state management in Edit Form mode * adapted target filter query add/update layout to use form layout * started adapting tags assignment * removed AbstractNotificationView * added row border in grids * fixed restoreState in Target Filters and Target Grid, refatored eventing in Deployment View * Added event listener for DsSetType * added confirmation window id for deletion support, added id for action type radio group, reworked restore state, small changes in Deployment view * started adapting ds grid, ds tags, action history and Deployment View layout * started adapting target grid * reworked Target Filter View and event handling * fixed Target Details error, started adapting Target Grid Layout * refactored Date time parser * fixed Date time parser * fixed formatting * fixed errors in auto close option * fixed errors in auto cleanup option * fixed errors in Polling view option * adapted filter management view and selection listener behaviour * cleanup, fix vaadin query to spring pageable convertion * adapted target tag filter layout * started adapting Deployment view * fixed software modules details grid rendering under Distribution Set Details * adapted artifact details grid popup window for Software Module details * adapted auto assignment details grid for DS * added get by ids to target tag management, adapted tag details layout for distribution set tag and target tag * package structure refactoring * started adapting software module details tab within distribution set details layout * excluded javax.validation because of a reference to an old sources file * fixed system config view misconfiguration * fixed ids formating, added UI access call for updating entities through listeners * refactored sm and ds types saving in proxy sm and ds entities * fixed software module to distribution set assignment and software module dataprovider in Distributions View * adapted add/update notification for software module and distribution set to show name and version, fixed search text field id * adapted software module color highlighting in Distributions View * adapted login ui * started adapting Distributions View * unified filter buttons click behaviour, added restore clicked filter to Upload View * removed duplications in filter headers * removed duplication in filter type/tag layouts * added sm and ds type remote events matchers for listener * adapted metadata details grid, update eventing fo details layout in Upload View * adapted entity deletion eventing and selection on restore state for Upload View * adapted file upload events handling, introduced RemoteEventsListener for the complete UI * adapted Details Header to render two separate labels for caption prefix (entity type) and entity name to prevent xss attack * upgraded vaadin to version 8.9.3, adapted upload artifact view and corresponding eventing further * change visibility of components instead of removing them in Upload View * adapted metadata popup window for target, distribution set and software module * first iteration of adapting metadata window layout: created meta data dataproviders and window grids for target, ds and sm * adapted auto assign window layout * further refactoring of Target filter view and layouts * adapted software module add/update window layout * adapted distribution set add/update window layout * refactored window layouts * fixed software module add/update layout, adapted target add/update layout * added validation of empty distribution set type software module types and mandatory property change * further refactoring of distribution set type add/update window * adapted distribution set type add/update window * adapted software module type add/update window layout * adapted tag layouts and color picker structure * adapted target and ds tag add/update windows, refactored color picker * added ds and sm type event containers * refactored local eventing and remote events handling, mainly only for distributions view * fixed ui alignment on the right side of the page * Finalized upload view migration * Fixed upload layout not enabled problem * Migrated Upload view. Some small glitches still open. * moved details headers to layouts * added callback to update last selected entity in UI state after each grid selection, unified all details layouts * further refactoring of Target Details * added selected event publishing to selection support, refactored target details * started unifying details layouts and adding details support classes * unified grid layouts * unified Target Filter Header * fixed glitches in UI regarding Headers, dapted eventing for crud menu and close header supports * unified types and tags headers * unified more headers * adapted TargetTableHeader to use AbstractGridHeader with Header Support classes, renamed to TargetGridHeader, removed unsused css properties * added CrudMenuHeaderSupport, refactored AbstractGridHeader * added AddHeaderSupport, BulkUploadHeaderSupport, CloseHeaderSupport, FilterButtonsHeaderSupport, ResizeHeaderSupport, SearchHeaderSupport, refactored ConfigMenuBar behaviour in MultipleTargetFilter * started unifying headers * extracted BulkUpload from AbstractTableHeader to TargetTableHeader * removed header row for tags and types grids, adapted margin/padding for some layouts, modified css properties for borders, updated vaadin version to 8.8.6, vaadin-spring to 3.2.1 * added javax servlet api maven dependency to hawkbit-autoconfigure, because gwt-user is not used anymore, fixed a couple of runtime errors, hawkbit starts :) * adapted TargetTableHeader drag and drop in order to filter targets by Distribution Sets, adapted gwt modules to inherit from compatibility Vaadin7WidgetSet, upgraded DistributionBar addon to be compatible with vaadin 8 * added NO TAG button to Target Tag and Distribution Tag layouts * adapted Distribution Set Types and Software Module Types layouts * adapted Target Tags layout, Distribution Set Tags Layout, added corresponding drag and drop supports * migrated from Table to Grid in TargetFilterQueryButtons, adapted click listeners * adapted twin columns layout for creating/updating Distribution Set Type * adapted MetaData Details classes * adapted AbstractMetadataPopupLayout and all children classes, refactored DeleteSupport * adapted Grid in UploadProgressInfoWindow * adapted software module details, target filter query details, removed custom combobox for autoassignment, adapted layouts and details * removed obsolete classes, adapted layouts as needed, removed Custom Renderers because components are used directly within the grids * added ArtifactDetailsGrid for Upload View, modified Artifact Layout to be consistent with Action History Layout in Deployment View, adapted Views and Layouts * added SoftwareModuleGrid to Upload View * migrated SwModuleTable to SwModuleGrid * migrated Distribution Set Table from Distributions View to Grid, refactored drag and drop * refactored target grid in Create/Update Filter View * refactored tag classes to use TagData where possible * migrated CreateOrupdateFilterTable to grid * adapted tag token classes * adapted Layouts, chaned Base Ui Event to except Proxy Entities * adapted TargetFilterGrid * Migrated TargetFilterTable to grid * Removed vaadin Tokenfield dependency * removed ConfirmationTab, using Component ConfirmationDialog instead; adapted MaintenanceWindowLayout, introduced AssignmentWindowLayout together with corresponding ComponentBuilder and Controller; added Drag and Drop support with differen Assignments support, adapted TargetGrid and DistributionGrid correspondingly; removed TargetAssignmentOperations utility class * second version of PinSupport * added DeleteSupport for target and distribution set items deletion * first draft of PinSupport for pinning targets and distribution setes * added first draft of Management Distribution Set Grid, adapted the corresponding data provider, adapted AbstractBaseViewFilter (should be checked) * first draft of Target Grid, refactored Selection support to include multi-selection mode * extracted single selection support, resize support and master details support from AbstractGrid, added filter type to AbstractGrid so the dataproviders are filterable by default, adapted some data providers to use filters, refactored master-details scenario for action history/status/msg layouts * Adapted AbstractGrid for resize support, adapted ActionHistoryGrid, ActionStatusGrid, ActionStatusMsgGrid * added rollout window specific classes (layouts, controllers, component builders) * changed Rollout/Group/Target List Grids to use vaadin 8 concepts, added temp utility classes * added ArtifactDataProvider and corresponding ProxyArtifact, SoftwareModuleArtifactsStateDataProvider, SoftwareModuleDistributionsStateDataProvider, TargetFilterStateDataProvider, TargetManagementStateDataProvider, TargetTagDataProvider and corresponding mappers * added parent Type model class for DistributionSetType and SoftwareModuleType and corresponding ProxyType, added ActionDataProvider, ActionStatusDataProvider, ActionStatusMsgDataProvider, DistributionSetTagDataProvider, DistributionSetTypeDataProvider, SoftwareModuleTypeDataProvider and corresponding mappers * extended data providers with filter, implemented multiple distribution set data providers for sifferent ui state (views), added target tag data provider, adapted Proxy Tag * added data providers, mappers and proxy classes for fetching entities from backend and mapping them to ui proxy entities * removed setImmediate on classes * fixed usage of option group layouts, removed all setImmediate calls * removed flexibleoptiongroup dependency and adapted the Option Group Layouts to use the default RadioButtonGroup * adapted Vaadin Security and fixed Notifications * Migrated vaadin 7 sources with the Vaadin migration tool to vaadin 8 compatibility mode Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
This was
linked to
issues
Jul 20, 2020
hawkbit-bot
reviewed
Jul 20, 2020
...-ui/src/main/java/org/eclipse/hawkbit/ui/common/layout/listener/LayoutViewAwareListener.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
...-ui/src/main/java/org/eclipse/hawkbit/ui/common/layout/listener/LayoutViewAwareListener.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/dstable/DistributionGridLayout.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/dstable/DistributionGridLayout.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/data/proxies/ProxySoftwareModule.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/filtermanagement/TargetFilterGridHeader.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/event/BulkUploadEventPayload.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/event/BulkUploadEventPayload.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/event/BulkUploadEventPayload.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/event/BulkUploadEventPayload.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
...main/java/org/eclipse/hawkbit/ui/common/filterlayout/AbstractFilterButtonClickBehaviour.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
...src/main/java/org/eclipse/hawkbit/ui/management/targettag/filter/TargetTagFilterButtons.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/grid/support/PinSupport.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/grid/support/PinSupport.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/data/providers/ProxyDataProvider.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/data/proxies/ProxyIdNameVersion.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/filterlayout/AbstractFilterButtons.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/disttype/SmTypeSourceGrid.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
...c/main/java/org/eclipse/hawkbit/ui/management/targettag/filter/TargetFilterQueryButtons.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
.../src/main/java/org/eclipse/hawkbit/ui/common/detailslayout/DistributionSetDetailsHeader.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
...src/main/java/org/eclipse/hawkbit/ui/rollout/window/RolloutWindowLayoutComponentBuilder.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
...i/src/main/java/org/eclipse/hawkbit/ui/common/grid/support/assignment/AssignmentSupport.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
.../eclipse/hawkbit/ui/tenantconfiguration/window/SystemConfigWindowLayoutComponentBuilder.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/common/data/proxies/ProxyActionStatus.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/distributions/DistributionsView.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jul 20, 2020
...bit-ui/src/main/java/org/eclipse/hawkbit/ui/common/grid/header/AbstractEntityGridHeader.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Aug 3, 2020
...rg/eclipse/hawkbit/ui/tenantconfiguration/repository/ActionAutoCleanupConfigurationItem.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Aug 3, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/actionhistory/ActionStatusGrid.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Aug 3, 2020
...src/main/java/org/eclipse/hawkbit/ui/management/actionhistory/ActionStatusMsgGridLayout.java
Outdated
Show resolved
Hide resolved
@bogdan-bondar all required Sonar issues are addressed though Sonar/Github faces issues updating the comments. Thanks a lot! |
…tion behaviour (due to complex logic for preserving and limiting selection) disable edit/copy rollout on creation, small naming changes and java docs improvements Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
…mns hidable, stoped propagation of select all event in order to not select the text on the page Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
schabdo
reviewed
Aug 12, 2020
...bit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/TargetTagRepository.java
Show resolved
Hide resolved
schabdo
reviewed
Aug 12, 2020
schabdo
reviewed
Aug 12, 2020
schabdo
reviewed
Aug 12, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/RemoteEventsListener.java
Outdated
Show resolved
Hide resolved
schabdo
reviewed
Aug 12, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/RemoteEventsListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
…describe the use-case for the listener Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
…sed instead Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
This was referenced Sep 18, 2020
Closed
Closed
AmmarBikic
pushed a commit
to bosch-io/hawkbit
that referenced
this pull request
Oct 2, 2020
* Migrated Hawkbit UI to Vaadin 8 * fixed tag assignment messages * disable rollout buttons instead of hinding them in Rollout Grid * fix mssql db error * small improvements to remove duplications while creating labels and distribution set type combo * upgraded Vaadin to 8.11.1, upgraded jsoup to 1.11.2 (used by Vaadin 8.11.1), fixed selection in Metadata window, moved Rollout Window components to separate components package * moved DS/SM type combobox creation to FormComponentBuilder, fixed add to collection error in SoftwareModuleDetails, changed save entity icons to harddrive, common refactoring * removed duplications between breadcrumb grid headers (RolloutGroupGridHeader, RolloutGroupTargetGridHeader, TargetFilterDetailsGridHeader) * replace proxy type in proxy objects with simple type info * made all text fileds lazy (the timeout is 500ms), fixed add rollout window error on getting the bean from layout to controller * removed duplications between ds to tag and target to tag assignment supports, extracted assignment notification from HawkbitCommonUtils * fixed search input with caption overlap * refactored layout visibility and resize listeners * fixed approval strategy, adapted rollout advanced group ids to always increase * Combine created and modified column creation * remove Column<?, ?> variables * fix confirmation dialog line breaks * fix grids in details and filters * fix column creation for upload grids * add default ExpandRatio, fix rollouts and target filter * add default addColumn method and fix action grids * update deployment and rollout grid and grid css * fix grid column widths * refactored approval layout * adapted approval layout * refactored advanced rollout group layout * refactored advanced group definitions to use proxy bean * fixed copy rollout window enable save button * third draft of Rollout Window validation: added UNKNOWN validation status, validate all layouts after validation listener is added * second draft of Rollout Window Validation * first Rollout Window Validation draft for enable/disable save button * fixed custom target filter de-selection on delete, re-selection on update, reset edit/delete crud menu mode on custom filter tab selection * added error threshold validation on total target and number of groups change * added random ids to Proxy identifiable entities without defined ids * add universal check box generator * adapted Update and Approve Rollout Window Layout * adapted setting and getting bean values for Add and Copy Rollout layouts * fix setting ConfirmationDialog ID * refactor ConfirmationDialog to use a CommonDialogWindow internally * fix rollout group definition input width * remove code duplication in UI grid column creation * refactored rollout group pie chart and legend by extracing them to their own class VisualGroupDefinitionLayout * remove code duplication on link creation * moved creation of AutoStartOptionGroupLayout to FormComponentBuilder * extracted RolloutFormLayout and SimpleGroupsLayout together with corresponding proxy beans from AddRolloutWindowLayout, adapted code accordingly * move TimeforcedIcon generation to StatusIconBuilder * move code to StatusIconBuilder * use objects to build labels from entity states * use generic method to generate status icon labels * moved AdvancedGroupRow from DefineGroupsLayout to separate class * remove code duplication on icon creation * removed Optionals from Data Providers * fixed remaining parts of xss vulnarable components (tags/types) * added description to key-value details pairs, moved the logic of paginated database access to HawkbitCommonUtils * further adapted xss atack posibilities * adapted details header and key-value details * adapted MetaData header * adapted Artifact and Action History Grid headers * adapted artifact download * adapted already assigned notification and rollout approval permission check * removed tenant and username cookies from hawkbit login * adapted attributes sorting by key * adapted controller attributes details * removed grid ResizeSupport (can be introduced later if needed) * refactored grids to not use resizeSupport but rather removing all columns and re-adding them after max/min state transition * fixed selection of added items * moved restoreState to AbstractGrid * unified Ds grids on Distribution and Deployment Views * moved filter support and drag and drop support to AbstractGrid * removed stale Sm grid id for Upload view * removed duplication between SwModuleGrid and SoftwareModuleGrid * removed unneccessary status icons css properties * added grid MasterEntitySupport, adapted grids * fixed tags/types filter deselection after deletion * fixed deletion success notification, added artifact uploads count check to software module table * unified target/ds/sm grid headers * unified DS and SM grid headers and details * added Delete Support to Rollout, adapted deletion permissions * introduced EntityResizeSupport, upgraded vaadin version to 8.10.4 * unified ds and sm type filter components * removed duplications between Target and Ds tag filters * removed duplication for #buildActionButton * initial iteration of removing duplications between grids * added GridActionsVisibilityListener * added layout visibility listener to filter and rollout views * unified LayoutResizeListener and LayoutVisibilityListener * extracted ShowEntityFormLayoutListener * refactored grid filter listeners * refactored target filter listeners, introduced filter support * added GenericEventListener, further unified listeners * partially unified LayoutViewAware event listeners, added PinningChangedListener, TagFilterListener and TypeFilterListener * fixed sql exception in case NO_TAG is selected without any additional tags active * unified entity modified listeners, adapted tag token modified update * fixed Upload View drop area enable on SM select * unified selection listeners * unified search listeners * added common SearchFilterListener, added temporare EntityModifiedMasterAwareSupport for EntityModifiedListener, fixed Rollout View change after rollout deletion/modification, adapted state restore * refactored entity modified and selection listeners together with support classes * added maintenance window and created/modified at tooltips in Action History Window, added id to Bulk Upload popup window and main popup layout, fixed duplicated DS error during DS edit/update * substituted ShowEntityDetailsEventPayload with SelectionChangedEventPayload in Rollout View for consistency with other Views, unified rollout ui state class * added builder to EntityModifiedListener, adapted code * refactored sm type modification of ds type * fix removing sm type from ds type via ui * refresh rollout group targets table on group-updated-event * moved grid label icon creation to SpUiComponent builder * fixed edit tag/type with invalid colour * added range validator(0-100) to trigger threshold * fixed rollout auto start option updates, fixed rollout grid search state restore, extended SPDateTimeUtil * Rollout Window Form fixes * small partial fix for error threshold percent/count validation and value change * fixed time forced empty datetime in Rollouts Update Window * added workaround for target/ds tags drag and drop due to the missing selection support * fixed ds unpinning after deletion and completion state change * added reason to bulk upload failed notification * fixed target add/update window form name id, introduced separate layout listeners for entity modified events and selection/master changed events, extended grid selection support, refactored corresponding grids, layouts and listeners * fixed required messages in the from builder, changed asyncExecutor to ui executor for file streaming, fixed auto-assignment for layout * fixed drag and drop registration for non-selection grid model, small restore state refactoring * fixed action remote events tests, adapted crudMenu/resize/search header supports to use mode-{mode} classes instead of ids modification * changed id of metadata popup grid to 'metadata.window.table.id' and details grid to '{typePrefix}.metadata.details.table.id', fixed tag/type cell text wrapping, tooltip shows full tag/type name, removed checkboxes from Distributions Set Type Software module selection grids * added tooltip to Rollout/RolloutGroup status bar, small bug fixes for Rollout Window target filter and approval * fixed edit permission validation in DetailsHeader * unbind distributionsview javascript from vaadin theme * small refactoring of form component builder, assignment and rollout layout * remove ds combobox code duplication, fix assig and autoassign popup * add BoundComponent class, fix assignment popup * remove duplicates for name, version description and actiontype fields * removed code duplication, fix assign- and autoassign-popup * adapted Action history eventing, changed entity modified parent event propagation * added id to DS details modules grid * started adapting Action History View * adapted filter by ds drop area restore * align drop styling with previous * fix filter target table by assigned ds * small refactoring of Deployment View and System config View layouts * adapted DS tag layout * fixed incompelete DS deselection and unpinning * added filter to RemoteEventListener in order to ignore remote events, added select entity on add to grids * fixed DS modules details, explained why session scope is used for bulk upload * adapted bulk upload window to be lazy loaded, fixed restore by usinng session scope * fixed user cell text selection in grid, drop hint highlighting * fixed undo for iot-update-server config option * fixed parsing in DurationField and refactored system config view * removed unused variable from DurationField * refactored config option view * fixed polling option value in config option view * fixed token refresh value in config option view * added binder auth config option * added binder to save config option * added binder for auto cleanup option * upgraded vaadin to 8.10.0, removed dd package together with CustomAcceptCriteria extension, removed CustomAcceptCriteria tests, removed all vaadin v7 dependencies, removed compatibility server and client * added selection by pressing key up/down, refactored range selection handler and connector, drag and drop support drop style listener, removed unneccessary styles for selection extension * show drop hint * fix h2 cast error * make unselected row dragable * add support for selection using Shift and CTRL * remove grid checkboxes, fix selection and drag and drop * moved bulk upload classes to own package, started implementing bulk upload window builder * further adaptations of bulk upload * started adapting bulk upload * partially removed stale classes/methods, vaadin v7 imports * completeted pinning refactoring * further pinning refactoring, added restore to distributions grid in deployment view * started adapting pinning of target and distribution set * further remote eventing refactoring, small styling adaptations * added 'maximize' and 'minimize' ids to max/min grid icons * removed event containers, adapting the delayed event bus push strategy, event provider and remote events listener * small eventing refactoring * adapted tag filter eventing, removed old event classes * adapted selection eventing, fixed color styling for grid selection, added countByAssignedId to softwaremodulemanagement * adapted type filter eventing * adapted search filter eventing * adapted actions visibility change eventing in filter layouts * adapted layout eventing in Deployment View * adapted layout eventing in Distributions View * adapted layout eventing in Upload View * adapted entity modified eventing * adapted rollout eventing * fix rollout view and window styling * handle rollouts view remote events * adapted eventing in Rollouts View * fixed Target Filter session state management in Edit Form mode * adapted target filter query add/update layout to use form layout * started adapting tags assignment * removed AbstractNotificationView * added row border in grids * fixed restoreState in Target Filters and Target Grid, refatored eventing in Deployment View * Added event listener for DsSetType * added confirmation window id for deletion support, added id for action type radio group, reworked restore state, small changes in Deployment view * started adapting ds grid, ds tags, action history and Deployment View layout * started adapting target grid * reworked Target Filter View and event handling * fixed Target Details error, started adapting Target Grid Layout * refactored Date time parser * fixed Date time parser * fixed formatting * fixed errors in auto close option * fixed errors in auto cleanup option * fixed errors in Polling view option * adapted filter management view and selection listener behaviour * cleanup, fix vaadin query to spring pageable convertion * adapted target tag filter layout * started adapting Deployment view * fixed software modules details grid rendering under Distribution Set Details * adapted artifact details grid popup window for Software Module details * adapted auto assignment details grid for DS * added get by ids to target tag management, adapted tag details layout for distribution set tag and target tag * package structure refactoring * started adapting software module details tab within distribution set details layout * excluded javax.validation because of a reference to an old sources file * fixed system config view misconfiguration * fixed ids formating, added UI access call for updating entities through listeners * refactored sm and ds types saving in proxy sm and ds entities * fixed software module to distribution set assignment and software module dataprovider in Distributions View * adapted add/update notification for software module and distribution set to show name and version, fixed search text field id * adapted software module color highlighting in Distributions View * adapted login ui * started adapting Distributions View * unified filter buttons click behaviour, added restore clicked filter to Upload View * removed duplications in filter headers * removed duplication in filter type/tag layouts * added sm and ds type remote events matchers for listener * adapted metadata details grid, update eventing fo details layout in Upload View * adapted entity deletion eventing and selection on restore state for Upload View * adapted file upload events handling, introduced RemoteEventsListener for the complete UI * adapted Details Header to render two separate labels for caption prefix (entity type) and entity name to prevent xss attack * upgraded vaadin to version 8.9.3, adapted upload artifact view and corresponding eventing further * change visibility of components instead of removing them in Upload View * adapted metadata popup window for target, distribution set and software module * first iteration of adapting metadata window layout: created meta data dataproviders and window grids for target, ds and sm * adapted auto assign window layout * further refactoring of Target filter view and layouts * adapted software module add/update window layout * adapted distribution set add/update window layout * refactored window layouts * fixed software module add/update layout, adapted target add/update layout * added validation of empty distribution set type software module types and mandatory property change * further refactoring of distribution set type add/update window * adapted distribution set type add/update window * adapted software module type add/update window layout * adapted tag layouts and color picker structure * adapted target and ds tag add/update windows, refactored color picker * added ds and sm type event containers * refactored local eventing and remote events handling, mainly only for distributions view * fixed ui alignment on the right side of the page * Finalized upload view migration * Fixed upload layout not enabled problem * Migrated Upload view. Some small glitches still open. * moved details headers to layouts * added callback to update last selected entity in UI state after each grid selection, unified all details layouts * further refactoring of Target Details * added selected event publishing to selection support, refactored target details * started unifying details layouts and adding details support classes * unified grid layouts * unified Target Filter Header * fixed glitches in UI regarding Headers, dapted eventing for crud menu and close header supports * unified types and tags headers * unified more headers * adapted TargetTableHeader to use AbstractGridHeader with Header Support classes, renamed to TargetGridHeader, removed unsused css properties * added CrudMenuHeaderSupport, refactored AbstractGridHeader * added AddHeaderSupport, BulkUploadHeaderSupport, CloseHeaderSupport, FilterButtonsHeaderSupport, ResizeHeaderSupport, SearchHeaderSupport, refactored ConfigMenuBar behaviour in MultipleTargetFilter * started unifying headers * extracted BulkUpload from AbstractTableHeader to TargetTableHeader * removed header row for tags and types grids, adapted margin/padding for some layouts, modified css properties for borders, updated vaadin version to 8.8.6, vaadin-spring to 3.2.1 * added javax servlet api maven dependency to hawkbit-autoconfigure, because gwt-user is not used anymore, fixed a couple of runtime errors, hawkbit starts :) * adapted TargetTableHeader drag and drop in order to filter targets by Distribution Sets, adapted gwt modules to inherit from compatibility Vaadin7WidgetSet, upgraded DistributionBar addon to be compatible with vaadin 8 * added NO TAG button to Target Tag and Distribution Tag layouts * adapted Distribution Set Types and Software Module Types layouts * adapted Target Tags layout, Distribution Set Tags Layout, added corresponding drag and drop supports * migrated from Table to Grid in TargetFilterQueryButtons, adapted click listeners * adapted twin columns layout for creating/updating Distribution Set Type * adapted MetaData Details classes * adapted AbstractMetadataPopupLayout and all children classes, refactored DeleteSupport * adapted Grid in UploadProgressInfoWindow * adapted software module details, target filter query details, removed custom combobox for autoassignment, adapted layouts and details * removed obsolete classes, adapted layouts as needed, removed Custom Renderers because components are used directly within the grids * added ArtifactDetailsGrid for Upload View, modified Artifact Layout to be consistent with Action History Layout in Deployment View, adapted Views and Layouts * added SoftwareModuleGrid to Upload View * migrated SwModuleTable to SwModuleGrid * migrated Distribution Set Table from Distributions View to Grid, refactored drag and drop * refactored target grid in Create/Update Filter View * refactored tag classes to use TagData where possible * migrated CreateOrupdateFilterTable to grid * adapted tag token classes * adapted Layouts, chaned Base Ui Event to except Proxy Entities * adapted TargetFilterGrid * Migrated TargetFilterTable to grid * Removed vaadin Tokenfield dependency * removed ConfirmationTab, using Component ConfirmationDialog instead; adapted MaintenanceWindowLayout, introduced AssignmentWindowLayout together with corresponding ComponentBuilder and Controller; added Drag and Drop support with differen Assignments support, adapted TargetGrid and DistributionGrid correspondingly; removed TargetAssignmentOperations utility class * second version of PinSupport * added DeleteSupport for target and distribution set items deletion * first draft of PinSupport for pinning targets and distribution setes * added first draft of Management Distribution Set Grid, adapted the corresponding data provider, adapted AbstractBaseViewFilter (should be checked) * first draft of Target Grid, refactored Selection support to include multi-selection mode * extracted single selection support, resize support and master details support from AbstractGrid, added filter type to AbstractGrid so the dataproviders are filterable by default, adapted some data providers to use filters, refactored master-details scenario for action history/status/msg layouts * Adapted AbstractGrid for resize support, adapted ActionHistoryGrid, ActionStatusGrid, ActionStatusMsgGrid * added rollout window specific classes (layouts, controllers, component builders) * changed Rollout/Group/Target List Grids to use vaadin 8 concepts, added temp utility classes * added ArtifactDataProvider and corresponding ProxyArtifact, SoftwareModuleArtifactsStateDataProvider, SoftwareModuleDistributionsStateDataProvider, TargetFilterStateDataProvider, TargetManagementStateDataProvider, TargetTagDataProvider and corresponding mappers * added parent Type model class for DistributionSetType and SoftwareModuleType and corresponding ProxyType, added ActionDataProvider, ActionStatusDataProvider, ActionStatusMsgDataProvider, DistributionSetTagDataProvider, DistributionSetTypeDataProvider, SoftwareModuleTypeDataProvider and corresponding mappers * extended data providers with filter, implemented multiple distribution set data providers for sifferent ui state (views), added target tag data provider, adapted Proxy Tag * added data providers, mappers and proxy classes for fetching entities from backend and mapping them to ui proxy entities * removed setImmediate on classes * fixed usage of option group layouts, removed all setImmediate calls * removed flexibleoptiongroup dependency and adapted the Option Group Layouts to use the default RadioButtonGroup * adapted Vaadin Security and fixed Notifications * Migrated vaadin 7 sources with the Vaadin migration tool to vaadin 8 compatibility mode * fixed some minor sonar issues * fixed license headers * fixed dynamic stylesheet js license header * adapted java docs parameters description, removed unused event classes * fixed icon styles, made action icons a little bigger * fixed download artifact action icon column header, fixed styling for the target filter query add/update layout, made it more responsive instead of hardcoding pixel values * fixed Notification rendering regarding word wrap * fixed restore behaviour with the invalid target filter query in Filter View * replaced List collection with Set for better performance during DS pinning, tag assignment, target status filtering and rollout add/update window validation, ignored irrelevant sonar issues * disable crud menu button on no CUD permissions, disable Rollout Group Button on missing permissions, removed Target Metadata details tab on missing repository read permissions, removed Autoassignment DS details tab on missing target read permissions, added UIEventPermissionChecker/HawkbitEventPermissionChecker to verify if current user has the required permissions in order to receive push events/notifications * disable Autoassignment link in case of missing read repository permissions, disable TFQ save button in case of missing update target permissions * adapted ordering of columns in maximized state * limited selection in grids to 1000 entities, removed shift+ctrl selection behaviour (due to complex logic for preserving and limiting selection) disable edit/copy rollout on creation, small naming changes and java docs improvements * added java docs to notification class * fixed restoration of the default filter value for grids * added caption to Delete column in grids, made target filter grid columns hidable, stoped propagation of select all event in order to not select the text on the page * removed com.google.gwt.gwtmockito test dependency * renamed RemoteEventsListener to HawkbitEntityEventListener to better describe the use-case for the listener * changed Guava cache to Caffeine cache for EntityModified UI events * removed obsolete HawkbitErrorNotificationMessage, UINotification is used instead * added stacked notifications custom extension * removed unused JUnitParams dependency * fixed license header for ParallelNotificationConnector * set ui mode back to production Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
krishna-devolo
pushed a commit
to devolo/hawkbit
that referenced
this pull request
Sep 23, 2021
* Migrated Hawkbit UI to Vaadin 8 * fixed tag assignment messages * disable rollout buttons instead of hinding them in Rollout Grid * fix mssql db error * small improvements to remove duplications while creating labels and distribution set type combo * upgraded Vaadin to 8.11.1, upgraded jsoup to 1.11.2 (used by Vaadin 8.11.1), fixed selection in Metadata window, moved Rollout Window components to separate components package * moved DS/SM type combobox creation to FormComponentBuilder, fixed add to collection error in SoftwareModuleDetails, changed save entity icons to harddrive, common refactoring * removed duplications between breadcrumb grid headers (RolloutGroupGridHeader, RolloutGroupTargetGridHeader, TargetFilterDetailsGridHeader) * replace proxy type in proxy objects with simple type info * made all text fileds lazy (the timeout is 500ms), fixed add rollout window error on getting the bean from layout to controller * removed duplications between ds to tag and target to tag assignment supports, extracted assignment notification from HawkbitCommonUtils * fixed search input with caption overlap * refactored layout visibility and resize listeners * fixed approval strategy, adapted rollout advanced group ids to always increase * Combine created and modified column creation * remove Column<?, ?> variables * fix confirmation dialog line breaks * fix grids in details and filters * fix column creation for upload grids * add default ExpandRatio, fix rollouts and target filter * add default addColumn method and fix action grids * update deployment and rollout grid and grid css * fix grid column widths * refactored approval layout * adapted approval layout * refactored advanced rollout group layout * refactored advanced group definitions to use proxy bean * fixed copy rollout window enable save button * third draft of Rollout Window validation: added UNKNOWN validation status, validate all layouts after validation listener is added * second draft of Rollout Window Validation * first Rollout Window Validation draft for enable/disable save button * fixed custom target filter de-selection on delete, re-selection on update, reset edit/delete crud menu mode on custom filter tab selection * added error threshold validation on total target and number of groups change * added random ids to Proxy identifiable entities without defined ids * add universal check box generator * adapted Update and Approve Rollout Window Layout * adapted setting and getting bean values for Add and Copy Rollout layouts * fix setting ConfirmationDialog ID * refactor ConfirmationDialog to use a CommonDialogWindow internally * fix rollout group definition input width * remove code duplication in UI grid column creation * refactored rollout group pie chart and legend by extracing them to their own class VisualGroupDefinitionLayout * remove code duplication on link creation * moved creation of AutoStartOptionGroupLayout to FormComponentBuilder * extracted RolloutFormLayout and SimpleGroupsLayout together with corresponding proxy beans from AddRolloutWindowLayout, adapted code accordingly * move TimeforcedIcon generation to StatusIconBuilder * move code to StatusIconBuilder * use objects to build labels from entity states * use generic method to generate status icon labels * moved AdvancedGroupRow from DefineGroupsLayout to separate class * remove code duplication on icon creation * removed Optionals from Data Providers * fixed remaining parts of xss vulnarable components (tags/types) * added description to key-value details pairs, moved the logic of paginated database access to HawkbitCommonUtils * further adapted xss atack posibilities * adapted details header and key-value details * adapted MetaData header * adapted Artifact and Action History Grid headers * adapted artifact download * adapted already assigned notification and rollout approval permission check * removed tenant and username cookies from hawkbit login * adapted attributes sorting by key * adapted controller attributes details * removed grid ResizeSupport (can be introduced later if needed) * refactored grids to not use resizeSupport but rather removing all columns and re-adding them after max/min state transition * fixed selection of added items * moved restoreState to AbstractGrid * unified Ds grids on Distribution and Deployment Views * moved filter support and drag and drop support to AbstractGrid * removed stale Sm grid id for Upload view * removed duplication between SwModuleGrid and SoftwareModuleGrid * removed unneccessary status icons css properties * added grid MasterEntitySupport, adapted grids * fixed tags/types filter deselection after deletion * fixed deletion success notification, added artifact uploads count check to software module table * unified target/ds/sm grid headers * unified DS and SM grid headers and details * added Delete Support to Rollout, adapted deletion permissions * introduced EntityResizeSupport, upgraded vaadin version to 8.10.4 * unified ds and sm type filter components * removed duplications between Target and Ds tag filters * removed duplication for #buildActionButton * initial iteration of removing duplications between grids * added GridActionsVisibilityListener * added layout visibility listener to filter and rollout views * unified LayoutResizeListener and LayoutVisibilityListener * extracted ShowEntityFormLayoutListener * refactored grid filter listeners * refactored target filter listeners, introduced filter support * added GenericEventListener, further unified listeners * partially unified LayoutViewAware event listeners, added PinningChangedListener, TagFilterListener and TypeFilterListener * fixed sql exception in case NO_TAG is selected without any additional tags active * unified entity modified listeners, adapted tag token modified update * fixed Upload View drop area enable on SM select * unified selection listeners * unified search listeners * added common SearchFilterListener, added temporare EntityModifiedMasterAwareSupport for EntityModifiedListener, fixed Rollout View change after rollout deletion/modification, adapted state restore * refactored entity modified and selection listeners together with support classes * added maintenance window and created/modified at tooltips in Action History Window, added id to Bulk Upload popup window and main popup layout, fixed duplicated DS error during DS edit/update * substituted ShowEntityDetailsEventPayload with SelectionChangedEventPayload in Rollout View for consistency with other Views, unified rollout ui state class * added builder to EntityModifiedListener, adapted code * refactored sm type modification of ds type * fix removing sm type from ds type via ui * refresh rollout group targets table on group-updated-event * moved grid label icon creation to SpUiComponent builder * fixed edit tag/type with invalid colour * added range validator(0-100) to trigger threshold * fixed rollout auto start option updates, fixed rollout grid search state restore, extended SPDateTimeUtil * Rollout Window Form fixes * small partial fix for error threshold percent/count validation and value change * fixed time forced empty datetime in Rollouts Update Window * added workaround for target/ds tags drag and drop due to the missing selection support * fixed ds unpinning after deletion and completion state change * added reason to bulk upload failed notification * fixed target add/update window form name id, introduced separate layout listeners for entity modified events and selection/master changed events, extended grid selection support, refactored corresponding grids, layouts and listeners * fixed required messages in the from builder, changed asyncExecutor to ui executor for file streaming, fixed auto-assignment for layout * fixed drag and drop registration for non-selection grid model, small restore state refactoring * fixed action remote events tests, adapted crudMenu/resize/search header supports to use mode-{mode} classes instead of ids modification * changed id of metadata popup grid to 'metadata.window.table.id' and details grid to '{typePrefix}.metadata.details.table.id', fixed tag/type cell text wrapping, tooltip shows full tag/type name, removed checkboxes from Distributions Set Type Software module selection grids * added tooltip to Rollout/RolloutGroup status bar, small bug fixes for Rollout Window target filter and approval * fixed edit permission validation in DetailsHeader * unbind distributionsview javascript from vaadin theme * small refactoring of form component builder, assignment and rollout layout * remove ds combobox code duplication, fix assig and autoassign popup * add BoundComponent class, fix assignment popup * remove duplicates for name, version description and actiontype fields * removed code duplication, fix assign- and autoassign-popup * adapted Action history eventing, changed entity modified parent event propagation * added id to DS details modules grid * started adapting Action History View * adapted filter by ds drop area restore * align drop styling with previous * fix filter target table by assigned ds * small refactoring of Deployment View and System config View layouts * adapted DS tag layout * fixed incompelete DS deselection and unpinning * added filter to RemoteEventListener in order to ignore remote events, added select entity on add to grids * fixed DS modules details, explained why session scope is used for bulk upload * adapted bulk upload window to be lazy loaded, fixed restore by usinng session scope * fixed user cell text selection in grid, drop hint highlighting * fixed undo for iot-update-server config option * fixed parsing in DurationField and refactored system config view * removed unused variable from DurationField * refactored config option view * fixed polling option value in config option view * fixed token refresh value in config option view * added binder auth config option * added binder to save config option * added binder for auto cleanup option * upgraded vaadin to 8.10.0, removed dd package together with CustomAcceptCriteria extension, removed CustomAcceptCriteria tests, removed all vaadin v7 dependencies, removed compatibility server and client * added selection by pressing key up/down, refactored range selection handler and connector, drag and drop support drop style listener, removed unneccessary styles for selection extension * show drop hint * fix h2 cast error * make unselected row dragable * add support for selection using Shift and CTRL * remove grid checkboxes, fix selection and drag and drop * moved bulk upload classes to own package, started implementing bulk upload window builder * further adaptations of bulk upload * started adapting bulk upload * partially removed stale classes/methods, vaadin v7 imports * completeted pinning refactoring * further pinning refactoring, added restore to distributions grid in deployment view * started adapting pinning of target and distribution set * further remote eventing refactoring, small styling adaptations * added 'maximize' and 'minimize' ids to max/min grid icons * removed event containers, adapting the delayed event bus push strategy, event provider and remote events listener * small eventing refactoring * adapted tag filter eventing, removed old event classes * adapted selection eventing, fixed color styling for grid selection, added countByAssignedId to softwaremodulemanagement * adapted type filter eventing * adapted search filter eventing * adapted actions visibility change eventing in filter layouts * adapted layout eventing in Deployment View * adapted layout eventing in Distributions View * adapted layout eventing in Upload View * adapted entity modified eventing * adapted rollout eventing * fix rollout view and window styling * handle rollouts view remote events * adapted eventing in Rollouts View * fixed Target Filter session state management in Edit Form mode * adapted target filter query add/update layout to use form layout * started adapting tags assignment * removed AbstractNotificationView * added row border in grids * fixed restoreState in Target Filters and Target Grid, refatored eventing in Deployment View * Added event listener for DsSetType * added confirmation window id for deletion support, added id for action type radio group, reworked restore state, small changes in Deployment view * started adapting ds grid, ds tags, action history and Deployment View layout * started adapting target grid * reworked Target Filter View and event handling * fixed Target Details error, started adapting Target Grid Layout * refactored Date time parser * fixed Date time parser * fixed formatting * fixed errors in auto close option * fixed errors in auto cleanup option * fixed errors in Polling view option * adapted filter management view and selection listener behaviour * cleanup, fix vaadin query to spring pageable convertion * adapted target tag filter layout * started adapting Deployment view * fixed software modules details grid rendering under Distribution Set Details * adapted artifact details grid popup window for Software Module details * adapted auto assignment details grid for DS * added get by ids to target tag management, adapted tag details layout for distribution set tag and target tag * package structure refactoring * started adapting software module details tab within distribution set details layout * excluded javax.validation because of a reference to an old sources file * fixed system config view misconfiguration * fixed ids formating, added UI access call for updating entities through listeners * refactored sm and ds types saving in proxy sm and ds entities * fixed software module to distribution set assignment and software module dataprovider in Distributions View * adapted add/update notification for software module and distribution set to show name and version, fixed search text field id * adapted software module color highlighting in Distributions View * adapted login ui * started adapting Distributions View * unified filter buttons click behaviour, added restore clicked filter to Upload View * removed duplications in filter headers * removed duplication in filter type/tag layouts * added sm and ds type remote events matchers for listener * adapted metadata details grid, update eventing fo details layout in Upload View * adapted entity deletion eventing and selection on restore state for Upload View * adapted file upload events handling, introduced RemoteEventsListener for the complete UI * adapted Details Header to render two separate labels for caption prefix (entity type) and entity name to prevent xss attack * upgraded vaadin to version 8.9.3, adapted upload artifact view and corresponding eventing further * change visibility of components instead of removing them in Upload View * adapted metadata popup window for target, distribution set and software module * first iteration of adapting metadata window layout: created meta data dataproviders and window grids for target, ds and sm * adapted auto assign window layout * further refactoring of Target filter view and layouts * adapted software module add/update window layout * adapted distribution set add/update window layout * refactored window layouts * fixed software module add/update layout, adapted target add/update layout * added validation of empty distribution set type software module types and mandatory property change * further refactoring of distribution set type add/update window * adapted distribution set type add/update window * adapted software module type add/update window layout * adapted tag layouts and color picker structure * adapted target and ds tag add/update windows, refactored color picker * added ds and sm type event containers * refactored local eventing and remote events handling, mainly only for distributions view * fixed ui alignment on the right side of the page * Finalized upload view migration * Fixed upload layout not enabled problem * Migrated Upload view. Some small glitches still open. * moved details headers to layouts * added callback to update last selected entity in UI state after each grid selection, unified all details layouts * further refactoring of Target Details * added selected event publishing to selection support, refactored target details * started unifying details layouts and adding details support classes * unified grid layouts * unified Target Filter Header * fixed glitches in UI regarding Headers, dapted eventing for crud menu and close header supports * unified types and tags headers * unified more headers * adapted TargetTableHeader to use AbstractGridHeader with Header Support classes, renamed to TargetGridHeader, removed unsused css properties * added CrudMenuHeaderSupport, refactored AbstractGridHeader * added AddHeaderSupport, BulkUploadHeaderSupport, CloseHeaderSupport, FilterButtonsHeaderSupport, ResizeHeaderSupport, SearchHeaderSupport, refactored ConfigMenuBar behaviour in MultipleTargetFilter * started unifying headers * extracted BulkUpload from AbstractTableHeader to TargetTableHeader * removed header row for tags and types grids, adapted margin/padding for some layouts, modified css properties for borders, updated vaadin version to 8.8.6, vaadin-spring to 3.2.1 * added javax servlet api maven dependency to hawkbit-autoconfigure, because gwt-user is not used anymore, fixed a couple of runtime errors, hawkbit starts :) * adapted TargetTableHeader drag and drop in order to filter targets by Distribution Sets, adapted gwt modules to inherit from compatibility Vaadin7WidgetSet, upgraded DistributionBar addon to be compatible with vaadin 8 * added NO TAG button to Target Tag and Distribution Tag layouts * adapted Distribution Set Types and Software Module Types layouts * adapted Target Tags layout, Distribution Set Tags Layout, added corresponding drag and drop supports * migrated from Table to Grid in TargetFilterQueryButtons, adapted click listeners * adapted twin columns layout for creating/updating Distribution Set Type * adapted MetaData Details classes * adapted AbstractMetadataPopupLayout and all children classes, refactored DeleteSupport * adapted Grid in UploadProgressInfoWindow * adapted software module details, target filter query details, removed custom combobox for autoassignment, adapted layouts and details * removed obsolete classes, adapted layouts as needed, removed Custom Renderers because components are used directly within the grids * added ArtifactDetailsGrid for Upload View, modified Artifact Layout to be consistent with Action History Layout in Deployment View, adapted Views and Layouts * added SoftwareModuleGrid to Upload View * migrated SwModuleTable to SwModuleGrid * migrated Distribution Set Table from Distributions View to Grid, refactored drag and drop * refactored target grid in Create/Update Filter View * refactored tag classes to use TagData where possible * migrated CreateOrupdateFilterTable to grid * adapted tag token classes * adapted Layouts, chaned Base Ui Event to except Proxy Entities * adapted TargetFilterGrid * Migrated TargetFilterTable to grid * Removed vaadin Tokenfield dependency * removed ConfirmationTab, using Component ConfirmationDialog instead; adapted MaintenanceWindowLayout, introduced AssignmentWindowLayout together with corresponding ComponentBuilder and Controller; added Drag and Drop support with differen Assignments support, adapted TargetGrid and DistributionGrid correspondingly; removed TargetAssignmentOperations utility class * second version of PinSupport * added DeleteSupport for target and distribution set items deletion * first draft of PinSupport for pinning targets and distribution setes * added first draft of Management Distribution Set Grid, adapted the corresponding data provider, adapted AbstractBaseViewFilter (should be checked) * first draft of Target Grid, refactored Selection support to include multi-selection mode * extracted single selection support, resize support and master details support from AbstractGrid, added filter type to AbstractGrid so the dataproviders are filterable by default, adapted some data providers to use filters, refactored master-details scenario for action history/status/msg layouts * Adapted AbstractGrid for resize support, adapted ActionHistoryGrid, ActionStatusGrid, ActionStatusMsgGrid * added rollout window specific classes (layouts, controllers, component builders) * changed Rollout/Group/Target List Grids to use vaadin 8 concepts, added temp utility classes * added ArtifactDataProvider and corresponding ProxyArtifact, SoftwareModuleArtifactsStateDataProvider, SoftwareModuleDistributionsStateDataProvider, TargetFilterStateDataProvider, TargetManagementStateDataProvider, TargetTagDataProvider and corresponding mappers * added parent Type model class for DistributionSetType and SoftwareModuleType and corresponding ProxyType, added ActionDataProvider, ActionStatusDataProvider, ActionStatusMsgDataProvider, DistributionSetTagDataProvider, DistributionSetTypeDataProvider, SoftwareModuleTypeDataProvider and corresponding mappers * extended data providers with filter, implemented multiple distribution set data providers for sifferent ui state (views), added target tag data provider, adapted Proxy Tag * added data providers, mappers and proxy classes for fetching entities from backend and mapping them to ui proxy entities * removed setImmediate on classes * fixed usage of option group layouts, removed all setImmediate calls * removed flexibleoptiongroup dependency and adapted the Option Group Layouts to use the default RadioButtonGroup * adapted Vaadin Security and fixed Notifications * Migrated vaadin 7 sources with the Vaadin migration tool to vaadin 8 compatibility mode * fixed some minor sonar issues * fixed license headers * fixed dynamic stylesheet js license header * adapted java docs parameters description, removed unused event classes * fixed icon styles, made action icons a little bigger * fixed download artifact action icon column header, fixed styling for the target filter query add/update layout, made it more responsive instead of hardcoding pixel values * fixed Notification rendering regarding word wrap * fixed restore behaviour with the invalid target filter query in Filter View * replaced List collection with Set for better performance during DS pinning, tag assignment, target status filtering and rollout add/update window validation, ignored irrelevant sonar issues * disable crud menu button on no CUD permissions, disable Rollout Group Button on missing permissions, removed Target Metadata details tab on missing repository read permissions, removed Autoassignment DS details tab on missing target read permissions, added UIEventPermissionChecker/HawkbitEventPermissionChecker to verify if current user has the required permissions in order to receive push events/notifications * disable Autoassignment link in case of missing read repository permissions, disable TFQ save button in case of missing update target permissions * adapted ordering of columns in maximized state * limited selection in grids to 1000 entities, removed shift+ctrl selection behaviour (due to complex logic for preserving and limiting selection) disable edit/copy rollout on creation, small naming changes and java docs improvements * added java docs to notification class * fixed restoration of the default filter value for grids * added caption to Delete column in grids, made target filter grid columns hidable, stoped propagation of select all event in order to not select the text on the page * removed com.google.gwt.gwtmockito test dependency * renamed RemoteEventsListener to HawkbitEntityEventListener to better describe the use-case for the listener * changed Guava cache to Caffeine cache for EntityModified UI events * removed obsolete HawkbitErrorNotificationMessage, UINotification is used instead * added stacked notifications custom extension * removed unused JUnitParams dependency * fixed license header for ParallelNotificationConnector * set ui mode back to production Signed-off-by: Bogdan Bondar <Bogdan.Bondar@bosch.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Bondar Bogdan.Bondar@bosch.io