Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support regex in SslContextFactory include/exclude of protocols #5535

Closed
joakime opened this issue Oct 30, 2020 · 1 comment · Fixed by #5538
Closed

Support regex in SslContextFactory include/exclude of protocols #5535

joakime opened this issue Oct 30, 2020 · 1 comment · Fixed by #5538
Assignees
@joakime
Labels
Enhancement

Comments

@joakime
Copy link
Contributor

joakime commented Oct 30, 2020

Jetty version
9.4.x

Description
In troubleshooting #5531 it was discovered that currently, only the SslContextFactory methods for include/exclude cipher suites support regex.
The include/exclude protocols does not.

We need to add this functionality.
@joakime joakime self-assigned this Oct 30, 2020
@joakime joakime mentioned this issue Oct 30, 2020
Closed
@joakime joakime changed the title Support regex in SslContextFactory .setExcludeProtocols and .setIncludeProtocols Support regex in SslContextFactory include/exclude of protocols Oct 30, 2020
joakime added a commit that referenced this issue Oct 30, 2020
@joakime
Issue #5535 - Adding regex include/exclude of Protocols to SslContext…
074b4f9 
…Factory

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime mentioned this issue Oct 30, 2020
Merged
@joakime joakime linked a pull request Oct 30, 2020 that will close this issue
Issue #5535 - Adding support for regex include/exclude of Protocols to SslContextFactory #5538
Merged
joakime added a commit that referenced this issue Oct 30, 2020
@joakime
Issue #5535 - Removing irrelevant lines on test
249cb02 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Oct 30, 2020
@joakime
Merge pull request #5538 from eclipse/jetty-9.4.x-5531-ssl-dump-proto…
1f727cd 
…cols

Issue #5535 - Adding support for regex include/exclude of Protocols to SslContextFactory
@joakime
Copy link
Contributor Author

joakime commented Oct 30, 2020

Merged into jetty-9.4.x.

@joakime joakime closed this as completed Oct 30, 2020
@joschi joschi mentioned this issue Nov 26, 2020
Merged
joschi added a commit to dropwizard/dropwizard that referenced this issue Nov 26, 2020
@joschi
Revert "Replace invalid default excludedProtocols in HttpsConnectorFa…
cf2230d 
…ctory" (#3579)

Jetty 9.4.34.v20201102 added support for regular expressions in included/excluded protocols.

https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.34.v20201102

Refs #3533
Refs jetty/jetty.project#5535
This partially reverts commit 206e858.
joschi added a commit to dropwizard/dropwizard that referenced this issue Nov 26, 2020
@joschi
Revert "Replace invalid default excludedProtocols in HttpsConnectorFa…
083fed8 
…ctory" (#3579)

Jetty 9.4.34.v20201102 added support for regular expressions in included/excluded protocols.

https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.34.v20201102

Refs #3533
Refs jetty/jetty.project#5535
This partially reverts commit 206e858.

(cherry picked from commit cf2230d)
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Enhancement
Projects
None yet
Milestone
No milestone
1 participant
@joakime