Jetty 9.4.x 5859 classloader leak queuedthreadpool #5894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
sbordet
requested changes
Jan 18, 2021
jetty-util/src/main/java/org/eclipse/jetty/util/thread/QueuedThreadPool.java
Outdated
Show resolved
Hide resolved
jetty-util/src/test/java/org/eclipse/jetty/util/thread/QueuedThreadPoolTest.java
Show resolved
Hide resolved
Signed-off-by: Jan Bartel <janb@webtide.com>
sbordet
approved these changes
Jan 19, 2021
…59-classloader-leak-queuedthreadpool
Signed-off-by: Jan Bartel <janb@webtide.com>
|
@gregw / @sbordet reviewing the OP's info from issue #5859, it seems to me that the QueuedThreadPool threads are also vulnerable to the problem he reported in the same issue regarding the ShutdownThread: namely the inheritance by a new Thread() of the calling AccessContext, containing a reference to the ProtectionDomain which has a reference to the current contextClassloader. So the fix he suggested for ShutdownThread I've also applied to the QueuedThreadPool, and also rolled the fix for the ShutdownThread into this PR instead of opening a separate PR for it. Please (re)review. |
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
sbordet
approved these changes
Jan 21, 2021
…59-classloader-leak-queuedthreadpool
…59-classloader-leak-queuedthreadpool
Signed-off-by: Jan Bartel <janb@webtide.com>
sbordet
approved these changes
Feb 1, 2021
janbartel
deleted the
jetty-9.4.x-5859-classloader-leak-queuedthreadpool
branch
This was referenced Mar 10, 2021
This was referenced Mar 10, 2021
marcambier
pushed a commit
to gravitee-io/old-gravitee-api-management
that referenced
this pull request
Nov 3, 2021
Jetty version has been upgraded in this commit : gravitee-io/gravitee-bom@6eb8566 It introduced mutliple regressions in APIM. Since 9.4.37, Jettys threads classloaders have been refactored to fix a leak (see jetty/jetty.project#5894). After this fix, threads classpath is override with local classpath, so it does not contain gravitee context class loader nomore (see https://github.com/eclipse/jetty.project/pull/5894/files#diff-6f0181889aa765771dd358e58fc07e2a7d7bfa44c451359e34e3eea574a5a79cR696). Created a JettyQueuedThreadPool, to override Jetty's default QueuedThreadPool and give the gravitee context class loader to created threads.
marcambier
pushed a commit
to gravitee-io/old-gravitee-api-management
that referenced
this pull request
Nov 3, 2021
Jetty version has been upgraded in this commit : gravitee-io/gravitee-bom@6eb8566 It introduced mutliple regressions in APIM. Since 9.4.37, Jettys threads classloaders have been refactored to fix a leak (see jetty/jetty.project#5894). After this fix, threads classpath is override with local classpath, so it does not contain gravitee context class loader nomore (see https://github.com/eclipse/jetty.project/pull/5894/files#diff-6f0181889aa765771dd358e58fc07e2a7d7bfa44c451359e34e3eea574a5a79cR696). Created a JettyQueuedThreadPool, to override Jetty's default QueuedThreadPool and give the gravitee context class loader to created threads.
marcambier
pushed a commit
to gravitee-io/old-gravitee-api-management
that referenced
this pull request
Nov 3, 2021
Jetty version has been upgraded in this commit : gravitee-io/gravitee-bom@6eb8566 It introduced mutliple regressions in APIM. Since 9.4.37, Jettys threads classloaders have been refactored to fix a leak (see jetty/jetty.project#5894). After this fix, threads classpath is override with local classpath, so it does not contain gravitee context class loader nomore (see https://github.com/eclipse/jetty.project/pull/5894/files#diff-6f0181889aa765771dd358e58fc07e2a7d7bfa44c451359e34e3eea574a5a79cR696). Created a JettyQueuedThreadPool, to override Jetty's default QueuedThreadPool and give the gravitee context class loader to created threads.
marcambier
pushed a commit
to gravitee-io/old-gravitee-api-management
that referenced
this pull request
Nov 3, 2021
Jetty version has been upgraded in this commit : gravitee-io/gravitee-bom@6eb8566 It introduced mutliple regressions in APIM. Since 9.4.37, Jettys threads classloaders have been refactored to fix a leak (see jetty/jetty.project#5894). After this fix, threads classpath is override with local classpath, so it does not contain gravitee context class loader nomore (see https://github.com/eclipse/jetty.project/pull/5894/files#diff-6f0181889aa765771dd358e58fc07e2a7d7bfa44c451359e34e3eea574a5a79cR696). Created a JettyQueuedThreadPool, to override Jetty's default QueuedThreadPool and give the gravitee context class loader to created threads.
phiz71
pushed a commit
to gravitee-io/old-gravitee-api-management
that referenced
this pull request
Nov 3, 2021
Jetty version has been upgraded in this commit : gravitee-io/gravitee-bom@6eb8566 It introduced mutliple regressions in APIM. Since 9.4.37, Jettys threads classloaders have been refactored to fix a leak (see jetty/jetty.project#5894). After this fix, threads classpath is override with local classpath, so it does not contain gravitee context class loader nomore (see https://github.com/eclipse/jetty.project/pull/5894/files#diff-6f0181889aa765771dd358e58fc07e2a7d7bfa44c451359e34e3eea574a5a79cR696). Created a JettyQueuedThreadPool, to override Jetty's default QueuedThreadPool and give the gravitee context class loader to created threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5859
Ensure that QueuedThreadPool threads have their initial context classloader explicitly set, rather than defaulting to whatever the calling thread is using.