Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6442 Remove IRC documentation #6454

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Fix #6442 Remove IRC documentation #6454

merged 3 commits into from
Jun 22, 2021

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Jun 21, 2021 •
edited by lachlan-roberts
Loading

Issue #6442

Removed IRC reference

@gregw
Fix #6442
7f6963f 
Removed IRC reference
@gregw gregw requested a review from WalkerWatch June 21, 2021 22:04
@gregw gregw changed the title Fix #6442 Fix #6442 Remove IRC documentation Jun 21, 2021
@gregw gregw requested a review from joakime June 21, 2021 22:08
janbartel
janbartel previously approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lachlan-roberts
lachlan-roberts requested changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@lachlan-roberts lachlan-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to remove this from the current documentation as well as the old_docs directory. There should be another file at src/main/asciidoc/contribution-guide/2-community.adoc with the same info.

This also needs to be done in 9.4.x.

@gregw gregw requested a review from lachlan-roberts June 22, 2021 07:17
@gregw gregw merged commit 291218b into jetty-10.0.x Jun 22, 2021
@gregw gregw deleted the jetty-10-6442-Remove-IRC-reference branch June 22, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbartel janbartel janbartel approved these changes

@joakime joakime joakime approved these changes

@WalkerWatch WalkerWatch Awaiting requested review from WalkerWatch

@lachlan-roberts lachlan-roberts Awaiting requested review from lachlan-roberts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gregw @joakime @janbartel @lachlan-roberts