feat: Improve error reporting in test case execution #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 93.09% 94.89% +1.79%
==========================================
Files 69 68 -1
Lines 4955 4954 -1
==========================================
+ Hits 4613 4701 +88
+ Misses 342 253 -89
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Mcthomas777
force-pushed
the
Improve-error-reporting-in-test-case
branch
2 times, most recently
from
2700f2c
to
c50d089
Compare
sebclrsn
requested changes
Aug 3, 2022
| @@ -252,6 +252,9 @@ def execute( | |||
| log.exception("Keyboard Interrupt detected") | |||
| exit_code = ExitCode.ONE_OR_MORE_TESTS_RAISED_UNEXPECTED_EXCEPTION | |||
| except Exception: | |||
| log.exception(f'Issue detected in the test-suite: {config["test_suite_list"]}!') | |||
| log.exception( | |||
There was a problem hiding this comment.
I don't get this, the principle of log.exception is to log the message at error level AND to print out the exception stack, so even without this change you'd see all of the errors
src/pykiso/exceptions.py
Outdated
|
|
||
|
|
||
| class PykisoError(Exception): | ||
| """Pykiso specific exception used as basis for all others.""" | ||
|
|
||
| def __str__(self): | ||
| logging.exception(self.message) |
There was a problem hiding this comment.
As discussed don't mix up logging and exceptions, just add the log.exception when the exceptions are caught
There was a problem hiding this comment.
Ok, right just wanted to display the full message, as I didn't know it will be anyway
Mcthomas777
force-pushed
the
Improve-error-reporting-in-test-case
branch
2 times, most recently
from
6a85519
to
fd7ab03
Compare
Mcthomas777
force-pushed
the
Improve-error-reporting-in-test-case
branch
2 times, most recently
from
9d5b462
to
40e022c
Compare
sebastianpfischer
requested changes
Aug 4, 2022
sebclrsn
reviewed
Aug 4, 2022
Mcthomas777
force-pushed
the
Improve-error-reporting-in-test-case
branch
from
40e022c
to
a00490e
Compare
sebclrsn
approved these changes
Aug 5, 2022
sebastianpfischer
approved these changes
Aug 5, 2022
Pog3k
pushed a commit
that referenced
this pull request
Aug 11, 2022
Co-authored-by: Julien THOMAS <external.julien.thomas@de.bosch.com>
Pog3k
pushed a commit
that referenced
this pull request
Aug 11, 2022
Co-authored-by: Julien THOMAS <external.julien.thomas@de.bosch.com>
Pog3k
pushed a commit
that referenced
this pull request
Aug 11, 2022
Co-authored-by: Julien THOMAS <external.julien.thomas@de.bosch.com>
Pog3k
pushed a commit
that referenced
this pull request
Aug 11, 2022
Co-authored-by: Julien THOMAS <external.julien.thomas@de.bosch.com>
Pog3k
added a commit
that referenced
this pull request
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.