Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: granularity in the installation #213

Conversation

sebastianpfischer
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #213 (81ea705) into master (041be95) will decrease coverage by 0.04%.
The diff coverage is 92.15%.

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   96.90%   96.87%   -0.04%     
==========================================
  Files          74       74              
  Lines        5814     5847      +33     
==========================================
+ Hits         5634     5664      +30     
- Misses        180      183       +3     
Impacted Files Coverage Δ
src/pykiso/lib/connectors/cc_usb.py 0.00% <0.00%> (ø)
src/pykiso/lib/auxiliaries/udsaux/uds_auxiliary.py 96.82% <100.00%> (+0.07%) ⬆️
src/pykiso/lib/connectors/cc_pcan_can.py 99.24% <100.00%> (+0.01%) ⬆️
src/pykiso/lib/connectors/cc_rtt_segger.py 96.22% <100.00%> (+0.07%) ⬆️
src/pykiso/lib/connectors/cc_serial.py 100.00% <100.00%> (ø)
...kiso/lib/connectors/cc_socket_can/cc_socket_can.py 98.66% <100.00%> (+0.05%) ⬆️
...o/lib/connectors/cc_socket_can/socketcan_to_trc.py 100.00% <100.00%> (ø)
src/pykiso/lib/connectors/cc_uart.py 97.22% <100.00%> (+0.07%) ⬆️
src/pykiso/lib/connectors/cc_vector_can.py 100.00% <100.00%> (ø)
src/pykiso/lib/connectors/cc_visa.py 98.61% <100.00%> (+0.06%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/pykiso/lib/connectors/cc_serial.py Outdated Show resolved Hide resolved
@sebastianpfischer sebastianpfischer force-pushed the feature/reorganise-dependencies branch 2 times, most recently from 8ade4cc to 6f3024f Compare January 22, 2023 20:49
@sebastianpfischer
Copy link
Contributor Author

The coverage is not reflecting the reality anymore, the improvement can be found here: https://app.codecov.io/gh/eclipse/kiso-testing/commit/58f0e4808752e6d05e39c3a236c8482720820074

@sebastianpfischer
Copy link
Contributor Author

Somehow there is a mismatch between the black versions used in Jenkins and the one we use... I could commit because it passed black formatting ^^ but Jenkins complains it does not.

@sebastianpfischer
Copy link
Contributor Author

Coverage of cc_usb.py should be done with #255

@sebastianpfischer sebastianpfischer merged commit 513ff4a into eclipse:master Feb 24, 2023
@sebastianpfischer sebastianpfischer deleted the feature/reorganise-dependencies branch February 24, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants