feat: added shutdown method to CCHannel [ready for review] #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
===========================================
+ Coverage 0 96.90% +96.90%
===========================================
Files 0 84 +84
Lines 0 6552 +6552
===========================================
+ Hits 0 6349 +6349
- Misses 0 203 +203
... and 81 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sebclrsn
requested review from
sebclrsn,
sebastianpfischer,
BKaDamien and
TedRio
sebclrsn
approved these changes
Jun 19, 2023
Co-authored-by: Sebastian Clerson <58192998+sebclrsn@users.noreply.github.com>
BKaDamien
approved these changes
Jun 19, 2023
| @@ -100,6 +100,10 @@ def close(self) -> None: | |||
| with self._lock: | |||
| self._cc_close() | |||
|
|
|||
| def shutdown(self) -> None: | |||
There was a problem hiding this comment.
You add a specific need for the PCAN connectror into the base connector class.
I don't think it's the right place
| for instance in self.instances.values(): | ||
| if callable(getattr(instance, "__del__", None)): | ||
| instance.__del__() | ||
| if callable(getattr(instance, "shutdown", None)): |
There was a problem hiding this comment.
In addition specific implementation of a behavior only needed for the PCAN.
Maybe a solution would be to decorate the close method for the PCAN connector to handle the trace creation.
As mentioned above, even before with the del implementation, it's not the right place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.