-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added shutdown method to CCHannel [ready for review] #310
Conversation
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
===========================================
+ Coverage 0 96.90% +96.90%
===========================================
Files 0 84 +84
Lines 0 6552 +6552
===========================================
+ Hits 0 6349 +6349
- Misses 0 203 +203
... and 81 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Sebastian Clerson <58192998+sebclrsn@users.noreply.github.com>
@@ -100,6 +100,10 @@ def close(self) -> None: | |||
with self._lock: | |||
self._cc_close() | |||
|
|||
def shutdown(self) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You add a specific need for the PCAN connectror into the base connector class.
I don't think it's the right place
for instance in self.instances.values(): | ||
if callable(getattr(instance, "__del__", None)): | ||
instance.__del__() | ||
if callable(getattr(instance, "shutdown", None)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition specific implementation of a behavior only needed for the PCAN.
Maybe a solution would be to decorate the close method for the PCAN connector to handle the trace creation.
As mentioned above, even before with the del implementation, it's not the right place
No description provided.