Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-enable active loggers and add context manager for ConfigRegistry #340

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

sebclrsn
Copy link
Contributor

@sebclrsn sebclrsn commented Aug 7, 2023

  • flatten log path assignment in cli.py
  • add a context manager to ConfigRegistry to ensure proper cleanup
  • re-enable previously deactivate loggers in initialize_loggers

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #340 (2d592ff) into master (bf2e182) will decrease coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 2d592ff differs from pull request most recent head 495dcd6. Consider uploading reports for the commit 495dcd6 to get more accurate results

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
- Coverage   97.03%   96.99%   -0.05%     
==========================================
  Files          85       85              
  Lines        6749     6759      +10     
==========================================
+ Hits         6549     6556       +7     
- Misses        200      203       +3     
Files Changed Coverage Δ
src/pykiso/cli.py 100.00% <ø> (ø)
src/pykiso/logging_initializer.py 99.23% <100.00%> (-0.77%) ⬇️
src/pykiso/test_setup/config_registry.py 94.00% <100.00%> (-1.66%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sebclrsn sebclrsn mentioned this pull request Aug 8, 2023
@sebclrsn sebclrsn merged commit 8a44579 into eclipse:master Aug 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants