fix: add event to avoid deadlocks on run_command calls #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… thread while an auxiliary is being deleted
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
=======================================
Coverage 97.09% 97.10%
=======================================
Files 85 85
Lines 6824 6830 +6
=======================================
+ Hits 6626 6632 +6
Misses 198 198
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sebastianpfischer
approved these changes
Oct 6, 2023
Pog3k
approved these changes
Oct 9, 2023
|
@TedRio, do you still want to review or do we merge it? |
|
Waiting for validation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a callback executed in _receive_message calls run_command while the auxiliary is being deleted, this run_command call never gets to acquire the lock (already acquired by delete_instance in the main thread) and _receive_message never terminates either.
This leads to deadlocks on delete_instance calls.
Solution is to add an event acting as a guard and preventing run_command to try and acquire the lock while the auxiliary is being deleted