feat: improve testsuite validation #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
==========================================
+ Coverage 97.09% 97.11% +0.01%
==========================================
Files 85 85
Lines 6824 6853 +29
==========================================
+ Hits 6626 6655 +29
Misses 198 198
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sebclrsn
reviewed
Oct 10, 2023
| @@ -36,3 +36,12 @@ repos: | |||
| hooks: | |||
| - id: commitizen | |||
| stages: [commit-msg] | |||
| - repo: https://github.com/codespell-project/codespell | |||
sebclrsn
reviewed
Oct 10, 2023
| file_paths and all([VALID_MODULE_NAME.match(file.name) for file in file_paths]) | ||
| ) | ||
| # Check that all sub folders of a nested testsuite have an __init__.py file | ||
| testsuite_folders = {filepath.parent for filepath in test_files_found} |
There was a problem hiding this comment.
Wouldn't it be easier to directly gather all parent folders of the different files within a set?
all_parent_folders = set(parent for file in test_files_found for parent in file.parents)
There was a problem hiding this comment.
I need those folders between.. i have seen users who nested testsuite folders and then every folder needs to be a module
sebastianpfischer
approved these changes
Oct 11, 2023
|
Is there anything to add in What's new section? |
sebclrsn
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve testsuite validation.
If test files are sleceted in child folders child folders must have an init file.
Support check for nested child folders.
Print error when init file is missing