-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add one trace file per test case or test run #484
feat: add one trace file per test case or test run #484
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #484 +/- ##
=======================================
Coverage 97.04% 97.04%
=======================================
Files 84 84
Lines 6764 6832 +68
=======================================
+ Hits 6564 6630 +66
- Misses 200 202 +2 ☔ View full report in Codecov by Sentry. |
if self.trace_running: | ||
log.warning("Trace is already started") | ||
return | ||
|
||
if self.raw_pcan_interface is None: | ||
self._cc_open() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trace should be started only if the channel is open. We also have locks to protect the resources and this is here a bypass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this cc_open
because if you use the logic with the auxiliary with auto_start to True, then the connection will not be opened then I can't start the pcan trace automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But sorry, if this is a functionality that should be provided with the auto-start, it needs to become a parameter and also started there. As of today, this is a API the user calls and should stay like that.
Can you please provide a fix for that?
Add the possibility for the user to get one trace can per TestCase or for every test run from the configuration of the
CCPCanCan
by adding one parameter.