Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement double threaded auxiliary interface #74

Conversation

BKaDamien
Copy link
Contributor

Add the double threaded auxiliary interface, to be able to test it the following connectors/auxes were adapted:

  • proxy_auxiliary : adapt it in order to use it with the double threaded auxiliary interface
  • communication_auxiliary: for testing purpose I have to convert it
  • cc_proxy: now use callback mechanism introduce by the brand new proxy auxiliary

In addition to this source code changes:

  • adapt/add some pytest (cc_proxy, proxy aux...)
  • adapt sphinx doc to the introduction of the double threaded auxiliary

BKaDamien and others added 27 commits March 23, 2022 10:34
feat: make the proxy agnostic of transitioning messages

* - change dut, proxy, example aux response handling

- change return type for c_pcan_can, cc_example, cc_proxy, cc_raw_loopback, ...
- change black version from pre-commit hooks
- change connector interface typehint
- run pre-commit

* - adapt record/uds aux to channel response type chnage

- adapt typehint

* - adapt test for lauterbach, pcan, proxy rtt_segger

* - correct com aux receive_message return

- adapt test

* - adapt proxy record dut tcp_ip and example  auxes pytest

* - correct last warning regarding pytestrecord_aux

- correct proxy mp aux pytest ravoid log creation
- adapt proxy aux

* - adapt conector base class typehint return

- avoid breaking changes on user side regrading com aux

* refactor: change connectors return type to ensure proxy auxiliary agnostic design

test: adapt the whole tests folder to connectors brand new return type

* - move paragraph related to connector parameters and return type under Communication channel

* - correct misspelling

* - adap rtt_segger return type : in exception raise return {"msg": None}

* - handle None return vale from wait_and_get_report in com aux

- extend com_aux pytest
- just rework connector mother class by using dedicated tx and rx lock
- add initialize loggers to dt aux interfcace
- remove return from finally clause in test_execution
- switch com aux to dt aux interface
- add missing docstring and inhert dt interface to abc
- rewrite connector interface pytest
- add double threaded proxy auxiliary
- add double threaded cc proxy channel
- add missing method get_aux_by_alias in confi registry
- rework cc_mp_proxy pytest
- add brand new impleenation of cc_proxy (with callback mechanism)
- rework cc_proxy pytest
- add dynamic aux oncfiguration in sphinx
- rework template example for com aux and proxy aux
feat: adapt communication auxiliary to use the double threaded interface instead of the threaded one
feat: adapt proxy auxiliary to use the double threaded interface instead of the threaded one
feat: adapt cc_proxy channel to callback mechanism introduce by the brand new proxy auxiliary
docs: add double threaded auxiliary reference and usage
test: adapt/add com_aux, proxy channel/aux, double threaded interface pytests
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #74 (adc0b47) into master (4611d4f) will increase coverage by 0.95%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   91.61%   92.57%   +0.95%     
==========================================
  Files          69       70       +1     
  Lines        5023     5115      +92     
==========================================
+ Hits         4602     4735     +133     
+ Misses        421      380      -41     
Impacted Files Coverage Δ
src/pykiso/connector.py 100.00% <100.00%> (+10.25%) ⬆️
src/pykiso/interfaces/dt_auxiliary.py 100.00% <100.00%> (ø)
.../pykiso/lib/auxiliaries/communication_auxiliary.py 100.00% <100.00%> (+1.56%) ⬆️
src/pykiso/lib/auxiliaries/proxy_auxiliary.py 100.00% <100.00%> (+2.54%) ⬆️
src/pykiso/lib/connectors/cc_mp_proxy.py 100.00% <100.00%> (ø)
src/pykiso/lib/connectors/cc_proxy.py 100.00% <100.00%> (ø)
src/pykiso/test_coordinator/test_execution.py 89.00% <100.00%> (ø)
src/pykiso/test_setup/config_registry.py 85.29% <100.00%> (+1.42%) ⬆️
..._control_auxiliary/instrument_control_auxiliary.py 94.31% <0.00%> (-2.28%) ⬇️
src/pykiso/test_coordinator/test_case.py 95.23% <0.00%> (-0.27%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4611d4f...adc0b47. Read the comment docs.

@BKaDamien BKaDamien requested review from Pog3k and sebclrsn June 22, 2022 15:33
src/pykiso/interfaces/dt_auxiliary.py Show resolved Hide resolved
src/pykiso/interfaces/dt_auxiliary.py Show resolved Hide resolved
src/pykiso/interfaces/dt_auxiliary.py Outdated Show resolved Hide resolved
src/pykiso/interfaces/dt_auxiliary.py Show resolved Hide resolved
src/pykiso/interfaces/dt_auxiliary.py Outdated Show resolved Hide resolved
src/pykiso/lib/connectors/cc_proxy.py Outdated Show resolved Hide resolved
docs/advanced_features/dynamic_conf.rst Outdated Show resolved Hide resolved
docs/advanced_features/dynamic_conf.rst Outdated Show resolved Hide resolved
docs/advanced_features/dynamic_conf.rst Show resolved Hide resolved
docs/advanced_features/dynamic_conf.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@sebastianpfischer sebastianpfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's new missing

Done

- rename detached_tx_callback in detach_tx_callback
- adapt pytest
src/pykiso/lib/auxiliaries/proxy_auxiliary.py Outdated Show resolved Hide resolved
@sebastianpfischer sebastianpfischer merged commit f5cd266 into eclipse:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants