-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ComAux ability to clear receiving buffer #86
feat: ComAux ability to clear receiving buffer #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation and additional parts also missing
What's new?
Robot framework not updated
Examples missing?
126fcd8
to
721669e
Compare
192ed8c
to
e07b80d
Compare
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 94.72% 94.72%
=======================================
Files 68 68
Lines 4906 4906
=======================================
Hits 4647 4647
Misses 259 259 Help us with your feedback. Take ten seconds to tell us how you rate us. |
e07b80d
to
16ad81d
Compare
So after our discussion:
|
04b9f67
to
f5f53ab
Compare
2b8f051
to
0692b2a
Compare
0692b2a
to
4416781
Compare
4416781
to
2e08240
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check Robot Version.
Or Create ticket to fix in future
570cabf
to
a16503f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some additional changes to do (like discussed offline)
7816eb7
to
67d05c6
Compare
0eff4d1
to
fbd7bef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our discussion, the code does not provide the required features yet
fbd7bef
to
56b6d57
Compare
73d2b35
to
e82d5b8
Compare
self.assertEqual(response, b"\x02\x04\x06") | ||
# check messages have not been queued in as | ||
# context manager wasn't used | ||
self.assertTrue(com_aux.queue_out.empty()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the test above, there is no element known that will populate the queue_out. Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To populate the queue send_message need to be in the ctx manager, otherwise you can not retrieve any messages
11ee349
to
0ace812
Compare
0ace812
to
4f70482
Compare
No description provided.