-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endless diagnostic publishing when validation is disabled #1175
Comments
I don't open any XML file. note that I'm running on the Remote - Containers extension connected to a CentOS 7 container. and that it happens on both Linux and WSL |
Ah, after restarting the container it didn't happen, so it's likely left over from when I did open an XML file, but I created this example file: <?xml version="1.0" encoding="UTF-8"?>
<test>
</test> and as soon as I opened it, it started happening. |
And do you benefit with syntax validation? |
I have this |
Could you enable xml trace https://github.com/redhat-developer/vscode-xml/blob/master/docs/Troubleshooting.md#no-support-on-xml-file and share your trace please
Ok but have you some XML features like completion, hover, linked editing range, etc? |
All of them seem to be loading forever. |
I'm just seeing this on repeat:
(As in, it's receiving this notification a bunch of times every second) |
I don't understand, if you set What is your trace when the language server is started? |
The impression that I have is that the language server started and (perhaps) the settings is not valid and doesn't take care of your enabled validation settings. The server crashes and restart again. Not sure with that but it's an idea. |
Attached is the startup trace |
@IdanHo do you use a specific container? Can you install a JDK in the container and point xml.java.home to it? |
@IdanHo thanks so much with your trace, I can reproduce the problem and I know how to fix it. For the moment to avoid having this trouble, please set |
Fixes eclipse-lemminx#1175 Signed-off-by: azerr <azerr@redhat.com>
Thanks! |
Fixes eclipse-lemminx#1175 Signed-off-by: azerr <azerr@redhat.com>
Fixes eclipse-lemminx#1175 Signed-off-by: azerr <azerr@redhat.com>
Fixes eclipse-lemminx#1175 Signed-off-by: azerr <azerr@redhat.com>
Fixes #1175 Signed-off-by: azerr <azerr@redhat.com>
this fixes a couple security issues linked to downloading remote resources. - eclipse-lemminx/lemminx#1171 - eclipse-lemminx/lemminx#1174 and a critical bug when validation is disabled, using 100% CPU: - eclipse-lemminx/lemminx#1175
@IdanHo vscode-xml 0.19.1, which includes a fix for this issue, has been released to the VS Code Marketplace |
this fixes a couple security issues linked to downloading remote resources. - eclipse-lemminx/lemminx#1171 - eclipse-lemminx/lemminx#1174 and a critical bug when validation is disabled, using 100% CPU: - eclipse-lemminx/lemminx#1175
That update indeed fixed the issue, thank you! |
After updating from version 0.18.2 (As part of the vscode-xml) extension the
lemminx-linux
binary is using 100% of my cpu. (Same behaviour with 0.18.3, 0.18.4, 0.19.0). I don't have a specific xml file to point to, since it does so as soon as I open a container, without opening any XML files. I don't have debug symbols, but after attaching with GDB, these are the locations of all the threads:The text was updated successfully, but these errors were encountered: