Make ICodeActionParticipant members default #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@angelozerr Could you please take a look at this PR? |
|
It looks good, could you please add throws CancellationException for each method of API like you suggested. |
vrubezhny
force-pushed
the
fixICodeActionParticipant-make-members-default
branch
from
d255d90 to
7bf64c2
Compare
Sure. Thanks for reminding! |
angelozerr
reviewed
May 16, 2023
...src/main/java/org/eclipse/lemminx/services/extensions/codeaction/ICodeActionParticipant.java
Show resolved
Hide resolved
vrubezhny
force-pushed
the
fixICodeActionParticipant-make-members-default
branch
from
7bf64c2 to
d0286af
Compare
|
Thanks so much @vrubezhny ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also this PR bumps lemminx version to 0.26.0-SNAPSHOT and adds
@since 0.26annotation to the newICodeActionParticipant.doCodeActionUnconditionalmethod