-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown
support for hover
documentation
#245
Comments
For now, the main issue I have with this approach is, escaped xml is swallowed during the markdown conversion. e.g for https://github.com/felixfbecker/PowerShellXSD/blob/master/Test.Types.ps1xml: |
Could we not create our own (very simply) markdown parser for that:
|
Fred i'm sorry to insist but i think we could use our xmlscanner to parse documentation and generate markdown. I think its not an hard task. No? |
From a technical perspective, it would probably be better/more efficient to reuse the xmlscanner. But I'm not sure how much work it will be to rewrite a complete markdown converter, I'm not sure it'll be as easy as you think. But feel free to explore that option |
Fixed issue with confusion between html and already markdown documentation. Wrote unit tests Fixes eclipse-lemminx#245 Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Fixed issue with confusion between html and already markdown documentation. Wrote unit tests Fixes eclipse-lemminx#245 Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Fixed issue with confusion between html and already markdown documentation. Wrote unit tests Fixes eclipse-lemminx#245 Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Fixed issue with confusion between html and already markdown documentation. Wrote unit tests Fixes eclipse-lemminx#245 Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Fixed issue with confusion between html and already markdown documentation. Wrote unit tests Fixes eclipse-lemminx#245 Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Fixed issue with confusion between html and already markdown documentation. Wrote unit tests Fixes eclipse-lemminx#245 Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Fixed issue with confusion between html and already markdown documentation. Wrote unit tests Fixes eclipse-lemminx#245 Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Fixed issue with confusion between html and already markdown documentation. Wrote unit tests Fixes #245 Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Markdown
support for hover
documentation
Currently, hover returns documentation as text, meaning if the content is actual html, then the client doesn't render it in a user-friendly way. See a hover over the
<packaging>
element of a pom.xml:We could probably transform the html doc into markdown, using the remark library, like in jdt.ls. That'd also add jsoup as a dependency of the project.
The text was updated successfully, but these errors were encountered: