Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion capability was lost in specific scenarios #522

Closed
angelozerr opened this issue Jul 18, 2019 · 0 comments · Fixed by #523
Closed

Completion capability was lost in specific scenarios #522

angelozerr opened this issue Jul 18, 2019 · 0 comments · Fixed by #523
Assignees
@angelozerr
Labels
bug Something isn't working completion This issue or enhancement is related to completion support
Milestone
v0.8.0

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Jul 18, 2019 •
edited
Loading

LSP4XML loose the completion capability from the client. For instance snippet completion capability is lost.

You can see the problem with vscode-xml when you trigger completion for encoding attribute. The apply completion should provide list of encoding and this features is broken. With this PR it fixes the problem, see the demo:

CompletionApplyDemo
@angelozerr angelozerr self-assigned this Jul 18, 2019
@angelozerr angelozerr added this to the v0.8.0 milestone Jul 18, 2019
angelozerr added a commit that referenced this issue Jul 18, 2019
@angelozerr
Loose of completion capability from the client
07b3dae 
Fix #522

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr added the bug Something isn't working label Jul 18, 2019
@angelozerr angelozerr mentioned this issue Jul 18, 2019
Merged
angelozerr added a commit that referenced this issue Jul 18, 2019
@angelozerr
Loose of completion capability from the client
a2701a0 
Fix #522

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jul 18, 2019
@angelozerr
Loose of completion capability from the client
9ab8970 
Fix #522

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jul 18, 2019
@angelozerr
Loose of completion capability from the client
b843b4a 
Fix #522

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jul 19, 2019
@angelozerr
Loss of completion capability from the client
c2f66d5 
Fix #522

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jul 19, 2019
@angelozerr
Loss of completion capability from the client
93759e8 
Fix #522

Signed-off-by: azerr <azerr@redhat.com>
fbricon pushed a commit that referenced this issue Jul 19, 2019
@angelozerr @fbricon
Loss of completion capability from the client
a89cc52 
Fix #522

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jul 22, 2019
@angelozerr
Loss of completion capability from the client
d0a7c5a 
Fix #522

Signed-off-by: azerr <azerr@redhat.com>
@fbricon fbricon changed the title Loose of completion capability from the client Loss of completion capability from the client Jul 22, 2019
@angelozerr angelozerr added the completion This issue or enhancement is related to completion support label Jul 23, 2019
@angelozerr angelozerr changed the title Loss of completion capability from the client Completion capability was lost in specific scenarios Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working completion This issue or enhancement is related to completion support
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Loss of completion capability from the client eclipse-lemminx/lemminx
1 participant
@angelozerr