Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code action for SemicolonRequiredInReference #665

Closed
angelozerr opened this issue Apr 28, 2020 · 4 comments · Fixed by #1223
Closed

Code action for SemicolonRequiredInReference #665

angelozerr opened this issue Apr 28, 2020 · 4 comments · Fixed by #1223
Labels
code action DTD enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@angelozerr
Copy link
Contributor

Given this XML file:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE article [
  <!ENTITY mdash "&#x2014;">
]>
<root>
  &mdash
</root>

There is an error for &mdash because it misses ; we should provide a code action to fix that to insert at the end of &mdash the missing ;

@yashTEF
Copy link
Contributor

yashTEF commented Mar 28, 2021

Hi @angelozerr,
I am a little new to language servers so this could help me in getting started.
For debugging lemMinx I'm thinking about creating a test plugin and declaring generic editors, contentTypes etc as extension points and implementing StreamConnectionProvider for the client, as mentioned here.
Is this the right way or there is a simpler way to debug the server?

@angelozerr
Copy link
Contributor Author

I dont know Who you want to debug lemminx but if you want to debug it with www eclipse ide you can create the launch. Please read eclipse-wildwebdeveloper/wildwebdeveloper#266 (comment) (replace lsp4xml with lemminx)

@datho7561
Copy link
Contributor

Hi @yashTEF. Are you still interested in working on this issue?

@yashTEF
Copy link
Contributor

yashTEF commented May 26, 2021

@datho7561 Sure, I am inspecting the code base and trying to understand it, However I might need some help.

@angelozerr angelozerr added this to the 0.21.0 milestone Jun 7, 2022
@angelozerr angelozerr added the enhancement New feature or request label Jun 29, 2022
@angelozerr angelozerr changed the title Code action for SemicolonRequiredInReference Code action for SemicolonRequiredInReference Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code action DTD enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants