Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ETagRequired error range #876

Closed
angelozerr opened this issue Sep 16, 2020 · 0 comments · Fixed by #897
Closed

Improve ETagRequired error range #876

angelozerr opened this issue Sep 16, 2020 · 0 comments · Fixed by #897
Assignees
@angelozerr
Labels
bug Something isn't working validation
Milestone
0.14.0

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Sep 16, 2020 •
edited
Loading

Given this XML file:

<foo>
  <bar></
</foo>

We have that:

image

Although the ETagRequired error range should highlight the start tag element:
@angelozerr angelozerr added bug Something isn't working validation labels Sep 16, 2020
@angelozerr angelozerr added this to the 0.14.0 milestone Sep 16, 2020
@angelozerr angelozerr self-assigned this Sep 16, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue Sep 18, 2020
@angelozerr
Improve ETagRequired error range
5ad8b61 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Sep 21, 2020
Closed
angelozerr added a commit to angelozerr/lemminx that referenced this issue Sep 21, 2020
@angelozerr
Improve ETagRequired error range
34c4606 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Sep 23, 2020
@angelozerr
Improve ETagRequired error range
4de695b 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Sep 23, 2020
@angelozerr
Improve ETagRequired error range
c41d538 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Sep 23, 2020
@angelozerr
Improve ETagRequired error range
905a409 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Sep 24, 2020
@angelozerr
Improve ETagRequired error range
aaa477c 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Sep 24, 2020
@angelozerr
Improve ETagRequired error range
2262ca1 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Sep 24, 2020
@angelozerr
Improve ETagRequired error range
3443530 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 1, 2020
@angelozerr
Improve ETagRequired error range
9aa1a27 
Fixes eclipse-lemminx#876

Signed-off-by: azerr azerr@redhat.com
@angelozerr angelozerr mentioned this issue Oct 1, 2020
Merged
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 3, 2020
@angelozerr
Improve ETagRequired error range
475f86a 
Fixes eclipse-lemminx#876

Signed-off-by: azerr azerr@redhat.com
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 3, 2020
@angelozerr
Improve ETagRequired error range
472cb4d 
Fixes eclipse-lemminx#876

Signed-off-by: azerr azerr@redhat.com
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 3, 2020
@angelozerr
Improve ETagRequired error range
433c786 
Fixes eclipse-lemminx#876

Signed-off-by: azerr azerr@redhat.com
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 5, 2020
@angelozerr
Improve ETagRequired error range
afc24fb 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 5, 2020
@angelozerr
Improve ETagRequired error range
8ec03b7 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 5, 2020
@angelozerr
Improve ETagRequired error range
aa7e21c 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 5, 2020
@angelozerr
Improve ETagRequired error range
3bfc828 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 5, 2020
@angelozerr
Improve ETagRequired error range
16eb95b 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 5, 2020
@angelozerr
Improve ETagRequired error range
319f925 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 5, 2020
@angelozerr
Improve ETagRequired error range
9c032b2 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 5, 2020
@angelozerr
Improve ETagRequired error range
6e16cdc 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 5, 2020
@angelozerr
Improve ETagRequired error range
efcfbaa 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 5, 2020
@angelozerr
Improve ETagRequired error range
a043eb3 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 8, 2020
@angelozerr
Improve ETagRequired error range
c577e30 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 8, 2020
@angelozerr
Improve ETagRequired error range
5428526 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 9, 2020
@angelozerr
Improve ETagRequired error range
3fa6e41 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 9, 2020
@angelozerr
Improve ETagRequired error range
1ea5eba 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 9, 2020
@angelozerr
Improve ETagRequired error range
281c085 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 9, 2020
@angelozerr
Improve ETagRequired error range
e7a9dd6 
Fixes eclipse-lemminx#876

Signed-off-by: azerr <azerr@redhat.com>
datho7561 pushed a commit that referenced this issue Oct 9, 2020
@angelozerr @datho7561
Improve ETagRequired error range
9f5f757 
Fixes #876

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working validation
Projects
None yet
Milestone
0.14.0
1 participant
@angelozerr