Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbols Max Items Computed doesn't work for 0 #898

Closed
datho7561 opened this issue Oct 1, 2020 · 1 comment · Fixed by #912
Closed

Symbols Max Items Computed doesn't work for 0 #898

datho7561 opened this issue Oct 1, 2020 · 1 comment · Fixed by #912
Assignees
@datho7561
Labels
bug Something isn't working symbols
Milestone
0.14.0

Comments

@datho7561
Copy link
Contributor

If xml.symbols.maxItemsComputed is set to 0, then all the symbols are still computed.
@datho7561 datho7561 self-assigned this Oct 7, 2020
@fbricon fbricon added the bug Something isn't working label Oct 7, 2020
@datho7561
Copy link
Contributor Author

The default value the server uses if no settings are passed to it is 0. This means no symbols would be shown in the clients that don't send a default configuration to LemMinX. Is this a good default, or should I make 5000 the default on the server side?

datho7561 added a commit to datho7561/lemminx that referenced this issue Oct 13, 2020
@datho7561
No symbols computed if max symbols is zero
5a70592 
Closes eclipse-lemminx#898

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Oct 13, 2020
Merged
datho7561 added a commit to datho7561/lemminx that referenced this issue Oct 13, 2020
@datho7561
No symbols computed if max symbols is zero
b43b0d6 
Closes eclipse-lemminx#898

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Oct 15, 2020
@datho7561
No symbols computed if max symbols is zero
446e12b 
Closes eclipse-lemminx#898

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Oct 15, 2020
@datho7561
No symbols computed if max symbols is zero
5e1f5c4 
Closes eclipse-lemminx#898

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Oct 15, 2020
@datho7561
No symbols computed if max symbols is zero
f00a685 
Closes eclipse-lemminx#898

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Oct 15, 2020
@datho7561
No symbols computed if max symbols is zero
3ba5084 
Closes eclipse-lemminx#898

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Oct 20, 2020
@datho7561
No symbols computed if max symbols is zero
a47d073 
Closes eclipse-lemminx#898

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Oct 23, 2020
@datho7561
No symbols computed if max symbols is zero
6fe0281 
Closes eclipse-lemminx#898

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr added this to the 0.14.0 milestone Oct 23, 2020
angelozerr pushed a commit that referenced this issue Oct 23, 2020
@datho7561 @angelozerr
No symbols computed if max symbols is zero
65504b4 
Closes #898

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
bug Something isn't working symbols
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

No symbols computed if max symbols is zero datho7561/lemminx
3 participants
@fbricon @angelozerr @datho7561