Add support for exiting immediately from a shutdown() request. #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
requested changes
Jun 25, 2021
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this pull request
Jun 25, 2021
Supports the capability, which means that language server shuts down when `shutdown` is received instead of when `exit` is received. See eclipse-lemminx/lemminx#1070 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this pull request
Jun 25, 2021
Supports the capability, which means that language server shuts down when `shutdown` is received instead of when `exit` is received. See eclipse-lemminx/lemminx#1070 Signed-off-by: David Thompson <davthomp@redhat.com>
- In languageclient 7.x, the client fails to send the necessary exit() once a shutdown() response is received from the language server - When client defines shouldLanguageServerExitOnShutdown as true, the language server will exit immediately after the shutdown request - Adjust CHANGELOG for a 0.17.1 release Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
datho7561
approved these changes
Jun 25, 2021
datho7561
added a commit
to datho7561/vscode-xml
that referenced
this pull request
Jun 25, 2021
Supports the capability, which means that language server shuts down when `shutdown` is received instead of when `exit` is received. See eclipse-lemminx/lemminx#1070 Signed-off-by: David Thompson <davthomp@redhat.com>
|
I have not tested but after debugging vscode languageclient 7.0.0 , the problem occured in shutdown process: It called:
I have not tested, but I think this commit microsoft/vscode-languageserver-node@6eef6d2#diff-1442f78812d67be25f18d3b5d82e8b4191ae2f939a900eac32d4360222c5d845R3349 should fix the issue. IMHO, once microsoft/vscode-languageserver-node@6eef6d2#diff-1442f78812d67be25f18d3b5d82e8b4191ae2f939a900eac32d4360222c5d845R3349 will be released, we should test it and remove the Anyway thanks @rgrunber for your patch! |
datho7561
added a commit
to redhat-developer/vscode-xml
that referenced
this pull request
Jun 25, 2021
Supports the capability, which means that language server shuts down when `shutdown` is received instead of when `exit` is received. See eclipse-lemminx/lemminx#1070 Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LemMinX (at least for those adopting vscode-languageclient 7.x) will not exit immediately after the client shuts down, and relies on the parent process watcher, which can take some time.
once a shutdown() response is received from the language server
language server will exit immediately after the shutdown request
Signed-off-by: Roland Grunberg rgrunber@redhat.com
The delay ensures the shutdown() response will be received by the client.