Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed closingBracketNewLine indent to match splitAttributeIndentSize #1085

Merged
merged 1 commit into from
Jul 15, 2021
Merged

changed closingBracketNewLine indent to match splitAttributeIndentSize #1085

merged 1 commit into from
Jul 15, 2021

Conversation

AlexXuChen
Copy link
Contributor

Changed closingBracketNewLine indent level to match splitAttributeIndentSize when both splitAttributeIndentSize and closingBracketNewLine are true.

Closes: redhat-developer/vscode-xml/issues/516

Signed-off-by: Alexander Chen alchen@redhat.com

@datho7561 datho7561 self-requested a review July 15, 2021 14:35
datho7561
datho7561 approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datho7561 datho7561 added this to the 0.17.2 milestone Jul 15, 2021
@datho7561 datho7561 merged commit 69720e8 into eclipse-lemminx:master Jul 15, 2021
@datho7561 datho7561 added bug Something isn't working formatting This issue or enhancement is related to formatting support labels Jul 15, 2021
@AlexXuChen AlexXuChen deleted the issue516_xml branch July 15, 2021 15:03
@AlexXuChen AlexXuChen mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working formatting This issue or enhancement is related to formatting support
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.

With splitAttributes and closingBracketNewLine, indent closing bracket as much as attributes
2 participants
@AlexXuChen @datho7561