Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit redirects #1174

Merged
merged 4 commits into from
Feb 14, 2022
Merged

limit redirects #1174

merged 4 commits into from
Feb 14, 2022

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Feb 14, 2022

  • Upversion to 0.19.0-SNAPSHOT
  • Fix typo in native-image.yaml
  • Limit resource downloads and redirects to http, https and ftp
  • update changelog

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@angelozerr
Copy link
Contributor

Could you update the changelog too please.

CI build is failing

Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@angelozerr
Copy link
Contributor

LGTM, tests are worling with my laptop.

If CI build is working, I'm OK to merge it.

@angelozerr angelozerr merged commit a4f7417 into eclipse-lemminx:master Feb 14, 2022
@angelozerr
Copy link
Contributor

Many thanks @fbricon !

@angelozerr angelozerr added this to the 0.18.5 milestone Feb 14, 2022
@fbricon fbricon deleted the limit-redirects branch February 14, 2022 15:15
fbricon added a commit to fbricon/wildwebdeveloper that referenced this pull request Feb 14, 2022
this fixes a couple security issues linked to downloading remote resources.
- eclipse-lemminx/lemminx#1171
- eclipse-lemminx/lemminx#1174
fbricon added a commit to fbricon/wildwebdeveloper that referenced this pull request Feb 15, 2022
this fixes a couple security issues linked to downloading remote resources.
- eclipse-lemminx/lemminx#1171
- eclipse-lemminx/lemminx#1174

and a critical bug when validation is disabled, using 100% CPU:
- eclipse-lemminx/lemminx#1175
mickaelistria pushed a commit to eclipse-wildwebdeveloper/wildwebdeveloper that referenced this pull request Feb 15, 2022
this fixes a couple security issues linked to downloading remote resources.
- eclipse-lemminx/lemminx#1171
- eclipse-lemminx/lemminx#1174

and a critical bug when validation is disabled, using 100% CPU:
- eclipse-lemminx/lemminx#1175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants