Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send (aggregated) server.document.open events at fixed periods. #1198

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

rgrunber
Copy link
Contributor

  • Use an executor with fixed period (1 day) to send server.document.open
    events (if any) to the client

Signed-off-by: Roland Grunberg rgrunber@redhat.com

@rgrunber rgrunber marked this pull request as draft April 27, 2022 22:57
@rgrunber
Copy link
Contributor Author

I've tried this out with a delay of 15min and it seems to behave as expected.

@rgrunber rgrunber force-pushed the restore-doc-telemetry branch from c8c6aa7 to 2a5d057 Compare April 28, 2022 13:23
@rgrunber rgrunber marked this pull request as ready for review April 28, 2022 13:23
@rgrunber
Copy link
Contributor Author

CC @fbricon , let me know if we should include this in the release.

- Send server.document.open approximately every other hour

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber force-pushed the restore-doc-telemetry branch from c246bec to 6e7bc98 Compare March 3, 2023 19:43
@datho7561 datho7561 self-requested a review March 6, 2023 15:22
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me!

@datho7561 datho7561 added enhancement New feature or request telemetry labels Mar 6, 2023
@datho7561 datho7561 added this to the 0.25.0 milestone Mar 6, 2023
@datho7561 datho7561 merged commit fb9eabd into eclipse-lemminx:main Mar 6, 2023
@rgrunber rgrunber deleted the restore-doc-telemetry branch March 6, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants