Add test for TreeLineTracker.getLineInformation #1228
Conversation
There was a problem hiding this comment.
Thanks for contributing. Hopefully the ECA process wasn't too much of a pain.
Quick question, did you create the change in Eclipse, VS Code, or neither ? I ask because when I format in Eclipse (and probably VS Code with Java support) it will re-adjust it so () -> gets placed right after BadLocationException.class, . The lambda function body is then indented only one level past the Asserts.assertThrows....
I'm not a committer here so @datho7561 can have a look. If you're fine with the change after the suggested update (inline), then let's merge.
| document.setIncremental(true); | ||
| Position position = document.positionAt(0); | ||
| position = new Position(-1, 0); | ||
| int offset = document.offsetAt(position); |
There was a problem hiding this comment.
I would avoid assigning the return statement to offset mainly because we're not using it. Just calling the method on the RHS as you're doing is enough to trigger the behaviour we want to test. That's the only (minor) improvement. I like the usage of assertThrows. Looks much cleaner.
| () -> { | ||
| TextDocument document = new TextDocument("", ""); | ||
| document.setIncremental(true); | ||
| Position position = document.positionAt(0); |
There was a problem hiding this comment.
Also just hit me that positionAt also throws BadLocationException, and if that did happen, this would just pass. I would just remove this line and have Position position = new Position(-1, 0);
org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/commons/TextDocumentTest.java
Outdated
Show resolved
Hide resolved
|
Thank you for the detailed feedback! 😄 For the formatting @rgrunber : |
| @@ -155,6 +156,16 @@ public void testEmptyDocumentInc() throws BadLocationException { | |||
|
|
|||
| } | |||
|
|
|||
| @Test | |||
| public void testGetLineInformation() throws BadLocationException { | |||
There was a problem hiding this comment.
I would rename this test with testPositionAsBadLocation
|
Thanks so much @lacinoire for your contribution! |
Hey 😊
I want to contribute the following test:
Test that a
org.eclipse.lemminx.commons.BadLocationExceptionis thrown when the parameterlineofPosition.<init>is set to-1.This tests the method
TreeLineTracker.getLineInformation.This test is based on the test
testEmptyDocumentInc.Curious to hear what you think!
(I wrote this test as part of a research study at TU Delft. Find out more)