Bind to a schema from an empty document #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
force-pushed
the
819-bind-to-schema
branch
2 times, most recently
from
5531e2e to
84224cd
Compare
|
I need to write tests, but the code should be good. |
angelozerr
reviewed
Dec 14, 2022
...ntentmodel/participants/codeactions/nogrammarconstraints/NoGrammarConstraintsCodeAction.java
Show resolved
Hide resolved
angelozerr
reviewed
Dec 14, 2022
...ntentmodel/participants/codeactions/nogrammarconstraints/NoGrammarConstraintsCodeAction.java
Show resolved
Hide resolved
angelozerr
reviewed
Dec 14, 2022
...ntentmodel/participants/codeactions/nogrammarconstraints/NoGrammarConstraintsCodeAction.java
Show resolved
Hide resolved
datho7561
force-pushed
the
819-bind-to-schema
branch
from
84224cd to
34024ff
Compare
datho7561
commented
Dec 14, 2022
...c/test/java/org/eclipse/lemminx/services/extensions/ErrorParticipantLanguageServiceTest.java
Outdated
Show resolved
Hide resolved
datho7561
force-pushed
the
819-bind-to-schema
branch
from
34024ff to
d7ef509
Compare
|
@datho7561 could you fix the conflict please. |
datho7561
force-pushed
the
819-bind-to-schema
branch
2 times, most recently
from
1ddec78 to
80b4663
Compare
Allows you to use the code action to bind to a schema when a document doesn't have a root element. Also, the bind schema CodeLens is shown when the document doesn't have a root element. It generates an element `placeholder-element-name` when the binding strategy requires a root element to function (eg. `schemaLocation`, `noNamespaceSchemaLocation`). It also uses `placeholder-element-name` when binding to a `.dtd` using a DOCTYPE declaration. Closes redhat-developer/vscode-xml#819 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
819-bind-to-schema
branch
from
80b4663 to
9355983
Compare
|
It works like a charm, thanks @datho7561 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to use the code action to bind to a schema when a document doesn't have a root element. Also, the bind schema CodeLens is shown when the document doesn't have a root element.
It generates an element
placeholder-element-namewhen the bindingstrategy requires a root element to function (eg.
schemaLocation,noNamespaceSchemaLocation). It also usesplaceholder-element-namewhen binding to a.dtdusing a DOCTYPE declaration.Closes redhat-developer/vscode-xml#819
Signed-off-by: David Thompson davthomp@redhat.com