-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support references in included files for codelens + diagnostics. #1452
Support references in included files for codelens + diagnostics. #1452
Conversation
e0ae33c
to
37891f9
Compare
Given this XML file: <docbook>
<xref linkend="s1" />
<section id="s1" />
<xref linkend="ch1" />
<xi:include href="sub-book.xml" />
</docbook> with <book>
<chapter id="ch1" />
<chapter id="ch2"/>
<xref linkend="s1" />
<xref linkend="s1" />
<xref linkend="ch1" />
<xref linkend="ch1" />
</book> and an expression like this: {
"pattern": "**/*.xml",
"expressions": [
{
"from": "xref/@linkend",
"to": "@id"
}
]
}
|
37891f9
to
2e1c7fd
Compare
02f5fba
to
b4c7d23
Compare
I think that it would be nice to disable this when |
I get a |
I would like to avoid doing that, because my idea is to remove all XSD, RNG support and delegate references with XML references. For XSD, xsd:include is not linked to xiinclude. For the moment the include is hard coded, but my idea is to give the capability to customize it when you write an xm reference expression like: {
"pattern": "**/*.xml",
"include": [
"include/@href",
"import/@href"
],
"expressions": [
{
"from": "xref/@linkend",
"to": "@id"
}
]
} |
b4c7d23
to
de3bd11
Compare
I removed the log |
de3bd11
to
dead8db
Compare
Signed-off-by: azerr <azerr@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks, Angelo!
Search references inincluded files for codelens + diagnostics.
Signed-off-by: azerr azerr@redhat.com